Issue 500533002: Revert of Keep a copy of page id in RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500533002: Revert of Keep a copy of page id in RenderViewHost. (Closed)

Created:
6 years, 4 months ago by Avi (use Gerrit)

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek, Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Keep a copy of page id in RenderViewHost. (patchset #1 of https://codereview.chromium.org/493853002/) Reason for revert: This hit canary and we're getting instrumented crashes. That's what we were looking for so let's back it out. Original issue's description: > Keep a copy of page id in RenderViewHost. > > This is an instrumented version of the patch that will be reverted in a few days. > This is meant to catch crashes in edge cases and log enough for us to repro > them. > > BUG=99379, 369661 > TEST=this is gonna crash for a few people > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291077 TBR=rsesek@chromium.org,creis@chromium.org NOTREECHECKS=true NOTRY=true BUG=99379, 369661 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291401

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -65 lines)			Patch
M	chrome/common/crash_keys.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	5 chunks	+2 lines, -28 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	4 chunks	+2 lines, -18 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/test/test_render_view_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/test_render_view_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Avi (use Gerrit)

Created Revert of Keep a copy of page id in RenderViewHost.

6 years, 4 months ago (2014-08-22 14:40:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/500533002/1

6 years, 4 months ago (2014-08-22 14:40:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (1) as 291401