Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 5005: Reorganize the declarations to have some grouping and logical ordering in tab... (Closed)

Created:
12 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reorganize the declarations to have some grouping and logical ordering in tab contents and web contents. Reorder the derived classes overrides to match, and reorder the definitions of the functions to match the order in the header file. This doesn't actually change any code. I removed a few functions that were declared but never implemented (!) as well as some that were marked vitual but were never overridden. I renamed some things to make them more consistent. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2634

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1654 lines, -1704 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_commands.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/debugger/debugger_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/html_dialog_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/encoding_menu_controller_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/native_ui_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/navigation_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/render_view_host_delegate.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents.h View 1 15 chunks +261 lines, -240 lines 0 comments Download
M chrome/browser/tab_contents.cc View 1 11 chunks +242 lines, -257 lines 0 comments Download
M chrome/browser/view_source_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_contents_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_contents.h View 13 chunks +175 lines, -202 lines 0 comments Download
M chrome/browser/web_contents.cc View 22 chunks +942 lines, -971 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
12 years, 2 months ago (2008-09-26 16:27:02 UTC) #1
huanr
12 years, 2 months ago (2008-09-26 19:17:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698