Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 500453003: Re-enable unit tests for auto-sizing. (Closed)

Created:
6 years, 4 months ago by rune
Modified:
6 years, 4 months ago
Reviewers:
levin, adamk
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Re-enable unit tests for auto-sizing. Enabling these tests pass for me locally on Linux. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/web/tests/WebViewTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rune
6 years, 4 months ago (2014-08-22 09:02:51 UTC) #1
levin
lgtm Even though I haven't touched the code recently I'll lgtm re-enabling my old tests. ...
6 years, 4 months ago (2014-08-22 16:25:35 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-22 17:34:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/500453003/1
6 years, 4 months ago (2014-08-22 17:35:00 UTC) #4
rune
Ah. Needs a Source/web OWNER.
6 years, 4 months ago (2014-08-22 17:42:42 UTC) #5
levin
On 2014/08/22 17:42:42, rune wrote: > Ah. Needs a Source/web OWNER. lol. I guess I ...
6 years, 4 months ago (2014-08-22 17:49:06 UTC) #6
rune
On 2014/08/22 17:49:06, levin wrote: > On 2014/08/22 17:42:42, rune wrote: > > Ah. Needs ...
6 years, 4 months ago (2014-08-22 17:55:57 UTC) #7
rune
The CQ bit was unchecked by rune@opera.com
6 years, 4 months ago (2014-08-22 17:56:08 UTC) #8
levin
On 2014/08/22 17:55:57, rune wrote: > On 2014/08/22 17:49:06, levin wrote: > > On 2014/08/22 ...
6 years, 4 months ago (2014-08-22 18:13:14 UTC) #9
adamk
lgtm for Source/web
6 years, 4 months ago (2014-08-25 21:19:48 UTC) #10
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-25 22:01:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/500453003/1
6 years, 4 months ago (2014-08-25 22:01:50 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 22:06:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 180869

Powered by Google App Engine
This is Rietveld 408576698