Extend functionality of MockFileSystem.move()

Extend functionality of MockFileSystem.move()

MockFileSystem.move() function was able to move only files extended its functionality to move directories also.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181195

[patro, 2014-08-22 10:32:32]

Kindly Review,

Thanks,
Shyam Patro

[Dirk Pranke, 2014-08-27 23:46:51]

lgtm

https://codereview.chromium.org/500453002/diff/100001/Tools/Scripts/webkitpy/...
File Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right):

https://codereview.chromium.org/500453002/diff/100001/Tools/Scripts/webkitpy/...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:274: if source_is_file:
nit: I don't see an advantage to the local variable here, so I'd just make this
'if self.isfile(source)'

https://codereview.chromium.org/500453002/diff/100001/Tools/Scripts/webkitpy/...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:278:
self.written_files[source] = None
nit: it would probably be slightly more idiomatic webkitpy-style to early exit
after line 278, remove the 'else:', and dedent the copytree case.

[patro, 2014-09-01 09:28:25]

https://codereview.chromium.org/500453002/diff/100001/Tools/Scripts/webkitpy/...
File Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right):

https://codereview.chromium.org/500453002/diff/100001/Tools/Scripts/webkitpy/...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:274: if source_is_file:
On 2014/08/27 23:46:51, Dirk Pranke wrote:
> nit: I don't see an advantage to the local variable here, so I'd just make
this
> 'if self.isfile(source)'

Done.

https://codereview.chromium.org/500453002/diff/100001/Tools/Scripts/webkitpy/...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:278:
self.written_files[source] = None
On 2014/08/27 23:46:51, Dirk Pranke wrote:
> nit: it would probably be slightly more idiomatic webkitpy-style to early exit
> after line 278, remove the 'else:', and dedent the copytree case.

Done.

[patro, 2014-09-01 09:28:32]

The CQ bit was checked by behara.ms@samsung.com

[commit-bot: I haz the power, 2014-09-01 09:29:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/behara.ms@samsung.com/500453002/120001

[commit-bot: I haz the power, 2014-09-01 10:03:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/21762)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25074)

[commit-bot: I haz the power, 2014-09-01 10:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-01 10:15:06]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[patro, 2014-09-01 11:41:41]

The CQ bit was checked by behara.ms@samsung.com

[commit-bot: I haz the power, 2014-09-01 11:42:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/behara.ms@samsung.com/500453002/120001

[commit-bot: I haz the power, 2014-09-01 11:57:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/21777)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25092)

[commit-bot: I haz the power, 2014-09-01 11:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-01 11:59:38]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/21781)

[patro, 2014-09-01 13:18:33]

The CQ bit was checked by behara.ms@samsung.com

[commit-bot: I haz the power, 2014-09-01 13:18:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/behara.ms@samsung.com/500453002/140001

[commit-bot: I haz the power, 2014-09-01 14:12:52]

Committed patchset #5 (id:140001) as 181195