DevTools: check for canForceCompositingMode before trying to emulate device metrics.

Source/devtools/front_end/OverridesView.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 205 matching lines @@
         this._deviceSelectElement.selectedIndex = devices.length - 1;
 
     this._deviceSelectElement.addEventListener("change", this._deviceSelected.bind(this), false);
     this._deviceSelectElement.addEventListener("dblclick", this._emulateButtonClicked.bind(this), false);
     this._deviceSelectElement.addEventListener("keypress", this._keyPressed.bind(this), false);
 
     var buttonsBar = this.element.createChild("div");
     var emulateButton = buttonsBar.createChild("button", "settings-tab-text-button");
     emulateButton.textContent = WebInspector.UIString("Emulate");
     emulateButton.addEventListener("click", this._emulateButtonClicked.bind(this), false);
+    this._emulateButton = emulateButton;
 
     var resetButton = buttonsBar.createChild("button", "settings-tab-text-button");
     resetButton.textContent = WebInspector.UIString("Reset");
     resetButton.addEventListener("click", this._resetButtonClicked.bind(this), false);
 
     this._viewportValueLabel = this.element.createChild("div", "overrides-device-value-label");
     this._viewportValueLabel.textContent = WebInspector.UIString("Viewport:");
     this._viewportValueElement = this._viewportValueLabel.createChild("span", "overrides-device-value");
 
     this._userAgentLabel = this.element.createChild("div", "overrides-device-value-label");
     this._userAgentLabel.textContent = WebInspector.UIString("User agent:");
     this._userAgentValueElement = this._userAgentLabel.createChild("span", "overrides-device-value");
 
     this._updateValueLabels();
+
+    WebInspector.overridesSupport.addEventListener(WebInspector.OverridesSupport.Events.CanForceCompositingModeChanged, this._canForceCompositingModeChanged, this);
+    WebInspector.overridesSupport.updateCanForceCompositingMode(this._canForceCompositingModeChanged.bind(this));
 }
 
 // Third element lists device metrics separated by 'x':
 // - screen width,
 // - screen height,
 // - device scale factor,
 // - font scale factor, or 0 to compute one (see: WebInspector.OverridesSupport.DeviceMetrics.computeFontScaleFactorForAndroid).
 // - text autosizing.
 WebInspector.OverridesView.DeviceTab._phones = [
     ["Apple iPhone 3GS",
@@ skipping 111 matching lines @@
      "Mozilla/5.0 (Linux; Android 4.3; Nexus 7 Build/JSS15Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.72 Safari/537.36",
      "1280x800x1.325x0x1"],
     ["Motorola Xoom, Xyboard",
      "Mozilla/5.0 (Linux; U; Android 3.0; en-us; Xoom Build/HRI39) AppleWebKit/525.10 (KHTML, like Gecko) Version/3.0.4 Mobile Safari/523.12.2",
      "1280x800x1x0x1"],
     ["Samsung Galaxy Tab 7.7, 8.9, 10.1",
      "Mozilla/5.0 (Linux; U; Android 2.2; en-us; SCH-I800 Build/FROYO) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1",
      "1280x800x1x0x1"],
     ["Samsung Galaxy Tab",
      "Mozilla/5.0 (Linux; U; Android 2.2; en-us; SCH-I800 Build/FROYO) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1",
-     "1024x600x0x1"],
+     "1024x600x1x0x1"],
 ];
 
 WebInspector.OverridesView.DeviceTab.prototype = {
     /**
      * @param {Event} e
      */
     _keyPressed: function(e)
     {
         if (e.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code)
             this._emulateButtonClicked();
     },
 
     _emulateButtonClicked: function()
     {
+        if (!WebInspector.overridesSupport.canForceCompositingMode())
+            return;
         var option = this._deviceSelectElement.options[this._deviceSelectElement.selectedIndex];
         WebInspector.overridesSupport.emulateDevice(option._metrics, option._userAgent);
     },
 
     _resetButtonClicked: function()
     {
         WebInspector.overridesSupport.reset();
     },
 
+    _canForceCompositingModeChanged: function()
+    {
+        this._emulateButton.disabled = !WebInspector.overridesSupport.canForceCompositingMode();
+    },
+
     _deviceSelected: function()
     {
         var option = this._deviceSelectElement.options[this._deviceSelectElement.selectedIndex];
         this._emulatedDeviceSetting.set(option.value);
         this._updateValueLabels();
     },
 
     _updateValueLabels: function()
     {
         var option = this._deviceSelectElement.options[this._deviceSelectElement.selectedIndex];
@@ skipping 14 matching lines @@
  * @extends {WebInspector.OverridesView.Tab}
  */
 WebInspector.OverridesView.ViewportTab = function()
 {
     WebInspector.OverridesView.Tab.call(this, "viewport", WebInspector.UIString("Viewport"), [WebInspector.settings.overrideDeviceMetrics, WebInspector.settings.overrideCSSMedia]);
     this.element.addStyleClass("overrides-viewport");
 
     const metricsSetting = WebInspector.settings.deviceMetrics.get();
     var metrics = WebInspector.OverridesSupport.DeviceMetrics.parseSetting(metricsSetting);
     var checkbox = this._createSettingCheckbox(WebInspector.UIString("Emulate viewport"), WebInspector.settings.overrideDeviceMetrics, this._onMetricsCheckboxClicked.bind(this));
+    this._overrideDeviceMetricsCheckbox = checkbox.querySelector("input");
     WebInspector.settings.deviceMetrics.addChangeListener(this._updateDeviceMetricsElement, this);
 
     this.element.appendChild(checkbox);
     this.element.appendChild(this._createDeviceMetricsElement(metrics));
     this.element.appendChild(this._createMediaEmulationElement());
     this._onMetricsCheckboxClicked(WebInspector.settings.overrideDeviceMetrics.get());
 
+    WebInspector.overridesSupport.addEventListener(WebInspector.OverridesSupport.Events.CanForceCompositingModeChanged, this._canForceCompositingModeChanged, this);
+    WebInspector.overridesSupport.updateCanForceCompositingMode(this._canForceCompositingModeChanged.bind(this));
 }
 
 WebInspector.OverridesView.ViewportTab.prototype = {
     /**
      * @param {boolean} enabled
      */
     _onMetricsCheckboxClicked: function(enabled)
     {
         if (enabled && !this._widthOverrideElement.value)
             this._widthOverrideElement.focus();
@@ skipping 41 matching lines @@
                 WebInspector.settings.deviceMetrics.set(value);
         }
     },
 
     /**
      * @param {WebInspector.OverridesSupport.DeviceMetrics} metrics
      */
     _createDeviceMetricsElement: function(metrics)
     {
         var fieldsetElement = WebInspector.SettingsTab.createSettingFieldset(WebInspector.settings.overrideDeviceMetrics);
+        this._overrideDeviceMetricsFieldset = fieldsetElement;
         fieldsetElement.id = "metrics-override-section";
 
         function swapDimensionsClicked(event)
         {
             var widthValue = this._widthOverrideElement.value;
             this._widthOverrideElement.value = this._heightOverrideElement.value;
             this._heightOverrideElement.value = widthValue;
             this._applyDeviceMetricsUserInput();
         }
 
@@ skipping 43 matching lines @@
         if (this._heightOverrideElement.value !== metrics.height)
             this._heightOverrideElement.value = metrics.height;
         if (this._deviceScaleFactorOverrideElement.value !== metrics.deviceScaleFactor)
             this._deviceScaleFactorOverrideElement.value = metrics.deviceScaleFactor;
         if (this._fontScaleFactorOverrideElement.value !== metrics.fontScaleFactor)
             this._fontScaleFactorOverrideElement.value = metrics.fontScaleFactor;
         if (this._textAutosizingOverrideCheckbox.checked !== metrics.textAutosizing)
             this._textAutosizingOverrideCheckbox.checked = metrics.textAutosizing;
     },
 
+    _canForceCompositingModeChanged: function()
+    {
+        this._overrideDeviceMetricsFieldset.disabled = !WebInspector.overridesSupport.canForceCompositingMode();
+        this._overrideDeviceMetricsCheckbox.disabled = !WebInspector.overridesSupport.canForceCompositingMode();
+    },
+
     _createMediaEmulationElement: function()
     {
         var checkbox = WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UIString("CSS media"), WebInspector.settings.overrideCSSMedia, true);
         var fieldsetElement = WebInspector.SettingsTab.createSettingFieldset(WebInspector.settings.overrideCSSMedia);
         checkbox.appendChild(fieldsetElement);
 
         var mediaSelectElement = fieldsetElement.createChild("select");
         var mediaTypes = WebInspector.CSSStyleModel.MediaTypes;
         var defaultMedia = WebInspector.settings.emulatedCSSMedia.get();
         for (var i = 0; i < mediaTypes.length; ++i) {
@@ skipping 316 matching lines @@
         cellElement.appendChild(document.createTextNode(" \u03B2: "));
         this._betaElement = this._createInput(cellElement, "device-orientation-override-beta", String(deviceOrientation.beta), this._applyDeviceOrientationUserInput.bind(this), true);
         cellElement.appendChild(document.createTextNode(" \u03B3: "));
         this._gammaElement = this._createInput(cellElement, "device-orientation-override-gamma", String(deviceOrientation.gamma), this._applyDeviceOrientationUserInput.bind(this), true);
 
         return fieldsetElement;
     }
 }
 
 WebInspector.OverridesView.SensorsTab.prototype.__proto__ = WebInspector.OverridesView.Tab.prototype;