Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 50043007: DevTools: check for canForceCompositingMode before trying to emulate device metrics. (Closed)

Created:
7 years, 1 month ago by dgozman
Modified:
7 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: check for canForceCompositingMode before trying to emulate device metrics. BUG=288959, 308422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161082

Patch Set 1 #

Patch Set 2 : Moved overrideSupport initialization earlier #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : Fixed comments. #

Patch Set 6 : #

Total comments: 5

Patch Set 7 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -6 lines) Patch
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M Source/devtools/front_end/OverridesSupport.js View 1 2 3 4 5 6 4 chunks +39 lines, -4 lines 0 comments Download
M Source/devtools/front_end/OverridesView.js View 1 2 3 4 5 6 9 chunks +22 lines, -1 line 0 comments Download
M Source/devtools/front_end/inspector.js View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
7 years, 1 month ago (2013-10-30 12:45:08 UTC) #1
pfeldman
Please rebaseline. https://codereview.chromium.org/50043007/diff/40001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/50043007/diff/40001/Source/devtools/protocol.json#newcode487 Source/devtools/protocol.json:487: { "name": "canForce", "type": "boolean", "description": "Whether ...
7 years, 1 month ago (2013-10-30 15:30:05 UTC) #2
dgozman
PTAL https://codereview.chromium.org/50043007/diff/40001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/50043007/diff/40001/Source/devtools/protocol.json#newcode487 Source/devtools/protocol.json:487: { "name": "canForce", "type": "boolean", "description": "Whether page ...
7 years, 1 month ago (2013-10-31 10:11:09 UTC) #3
pfeldman
https://codereview.chromium.org/50043007/diff/120001/Source/devtools/front_end/OverridesSupport.js File Source/devtools/front_end/OverridesSupport.js (right): https://codereview.chromium.org/50043007/diff/120001/Source/devtools/front_end/OverridesSupport.js#newcode38 Source/devtools/front_end/OverridesSupport.js:38: this.canForceCompositingMode = true; Should be private w/ accessor if ...
7 years, 1 month ago (2013-10-31 11:23:58 UTC) #4
dgozman
PTAL https://codereview.chromium.org/50043007/diff/120001/Source/devtools/front_end/OverridesSupport.js File Source/devtools/front_end/OverridesSupport.js (right): https://codereview.chromium.org/50043007/diff/120001/Source/devtools/front_end/OverridesSupport.js#newcode38 Source/devtools/front_end/OverridesSupport.js:38: this.canForceCompositingMode = true; On 2013/10/31 11:23:58, pfeldman wrote: ...
7 years, 1 month ago (2013-10-31 12:39:49 UTC) #5
dgozman
PTAL https://codereview.chromium.org/50043007/diff/250001/Source/devtools/front_end/inspector.js File Source/devtools/front_end/inspector.js (right): https://codereview.chromium.org/50043007/diff/250001/Source/devtools/front_end/inspector.js#newcode442 Source/devtools/front_end/inspector.js:442: this.overridesSupport.applyInitialOverrides(); OverridesSupport want to reveal OverridesView if overrides ...
7 years, 1 month ago (2013-10-31 16:38:05 UTC) #6
pfeldman
lgtm with a nit https://codereview.chromium.org/50043007/diff/250001/Source/devtools/front_end/OverridesSupport.js File Source/devtools/front_end/OverridesSupport.js (right): https://codereview.chromium.org/50043007/diff/250001/Source/devtools/front_end/OverridesSupport.js#newcode32 Source/devtools/front_end/OverridesSupport.js:32: * @extends {WebInspector.Object} We define ...
7 years, 1 month ago (2013-10-31 17:45:31 UTC) #7
dgozman
https://codereview.chromium.org/50043007/diff/250001/Source/devtools/front_end/OverridesSupport.js File Source/devtools/front_end/OverridesSupport.js (right): https://codereview.chromium.org/50043007/diff/250001/Source/devtools/front_end/OverridesSupport.js#newcode32 Source/devtools/front_end/OverridesSupport.js:32: * @extends {WebInspector.Object} On 2013/10/31 17:45:31, pfeldman wrote: > ...
7 years, 1 month ago (2013-10-31 17:57:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/50043007/310001
7 years, 1 month ago (2013-10-31 17:58:20 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 19:35:48 UTC) #10
Message was sent while issue was closed.
Change committed as 161082

Powered by Google App Engine
This is Rietveld 408576698