Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9021)

Unified Diff: build/android/pylib/gtest/setup.py

Issue 500423004: Refactor/cleanup WebRTC-specific Andorid glue code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/gtest_config.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/setup.py
diff --git a/build/android/pylib/gtest/setup.py b/build/android/pylib/gtest/setup.py
index 00a575350a217b9cae952c541bb817b1bfc15bcd..da885c0baa1504d0d4c303f1edee41cc53161224 100644
--- a/build/android/pylib/gtest/setup.py
+++ b/build/android/pylib/gtest/setup.py
@@ -46,29 +46,6 @@ _ISOLATE_FILE_PATHS = {
'third_party/WebKit/Source/web/WebKitUnitTests.isolate',
}
-# Paths relative to third_party/webrtc/ (kept separate for readability).
-_WEBRTC_ISOLATE_FILE_PATHS = {
- 'audio_decoder_unittests':
- 'modules/audio_coding/neteq/audio_decoder_unittests.isolate',
- 'common_audio_unittests': 'common_audio/common_audio_unittests.isolate',
- 'common_video_unittests': 'common_video/common_video_unittests.isolate',
- 'modules_tests': 'modules/modules_tests.isolate',
- 'modules_unittests': 'modules/modules_unittests.isolate',
- 'system_wrappers_unittests':
- 'system_wrappers/source/system_wrappers_unittests.isolate',
- 'test_support_unittests': 'test/test_support_unittests.isolate',
- 'tools_unittests': 'tools/tools_unittests.isolate',
- 'video_engine_tests': 'video_engine_tests.isolate',
- 'video_engine_core_unittests':
- 'video_engine/video_engine_core_unittests.isolate',
- 'voice_engine_unittests': 'voice_engine/voice_engine_unittests.isolate',
- 'webrtc_perf_tests': 'webrtc_perf_tests.isolate',
-}
-
-# Append the WebRTC tests with the full path from Chromium's src/ root.
-for webrtc_test, isolate_path in _WEBRTC_ISOLATE_FILE_PATHS.items():
- _ISOLATE_FILE_PATHS[webrtc_test] = 'third_party/webrtc/%s' % isolate_path
-
# Used for filtering large data deps at a finer grain than what's allowed in
# isolate files since pushing deps to devices is expensive.
# Wildcards are allowed.
@@ -121,7 +98,7 @@ def _GenerateDepsDirUsingIsolate(suite_name, isolate_file_path=None):
isolated_abs_path = os.path.join(
constants.GetOutDirectory(), '%s.isolated' % suite_name)
- assert os.path.exists(isolate_abs_path)
+ assert os.path.exists(isolate_abs_path), 'Cannot find %s' % isolate_abs_path
# This needs to be kept in sync with the cmd line options for isolate.py
# in src/build/isolate.gypi.
isolate_cmd = [
« no previous file with comments | « build/android/pylib/gtest/gtest_config.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698