Enhance GN diagnostic tools

tools/gn/setup.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/setup.h"
 
 #include <stdlib.h>
 
 #include <algorithm>
 #include <sstream>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/process/launch.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
+#include "tools/gn/commands.h"
 #include "tools/gn/filesystem_utils.h"
-#include "tools/gn/header_checker.h"
 #include "tools/gn/input_file.h"
 #include "tools/gn/parse_tree.h"
 #include "tools/gn/parser.h"
 #include "tools/gn/source_dir.h"
 #include "tools/gn/source_file.h"
 #include "tools/gn/standard_out.h"
 #include "tools/gn/tokenizer.h"
 #include "tools/gn/trace.h"
 #include "tools/gn/value.h"
 
@@ skipping 148 matching lines @@
   if (check_for_unused_overrides_) {
     if (!build_settings_.build_args().VerifyAllOverridesUsed(&err)) {
       // TODO(brettw) implement a system of warnings. Until we have a better
       // system, print the error but don't return failure.
       err.PrintToStdout();
       return true;
     }
   }
 
   if (check_public_headers_) {
-    std::vector<const Target*> targets = builder_->GetAllResolvedTargets();
-    scoped_refptr<HeaderChecker> header_checker(
-        new HeaderChecker(&build_settings_, targets));
-
-    std::vector<Err> header_errors;
-    header_checker->Run(&header_errors);
-    for (size_t i = 0; i < header_errors.size(); i++) {
-      if (i > 0)
-        OutputString("___________________\n", DECORATION_YELLOW);
-      header_errors[i].PrintToStdout();
+    if (!commands::CheckPublicHeaders(&build_settings_,
+                                      builder_->GetAllResolvedTargets(),
+                                      std::vector<const Target*>())) {
+      return false;
     }
-    if (!header_errors.empty())
-      return false;
   }
 
   // Write out tracing and timing if requested.
   const CommandLine* cmdline = CommandLine::ForCurrentProcess();
   if (cmdline->HasSwitch(kTimeSwitch))
     PrintLongHelp(SummarizeTraces());
   if (cmdline->HasSwitch(kTracelogSwitch))
     SaveTraces(cmdline->GetSwitchValuePath(kTracelogSwitch));
 
   return true;
@@ skipping 382 matching lines @@
 }
 
 void DependentSetup::RunPreMessageLoop() {
   CommonSetup::RunPreMessageLoop();
 }
 
 bool DependentSetup::RunPostMessageLoop() {
   return CommonSetup::RunPostMessageLoop();
 }