Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: src/code-stubs.h

Issue 500423002: Minor-key-ify new LoadICTrampolineStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index c43cb2f3efc56acf3080dd0c8e9b2999912c1b07..dea29dcbc55e01354251880e22509182ef0ae0bb 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1944,7 +1944,9 @@ class KeyedLoadGenericStub : public HydrogenCodeStub {
class LoadICTrampolineStub : public PlatformCodeStub {
public:
LoadICTrampolineStub(Isolate* isolate, const LoadIC::State& state)
- : PlatformCodeStub(isolate), state_(state) {}
+ : PlatformCodeStub(isolate) {
+ minor_key_ = state.GetExtraICState();
+ }
virtual Code::Kind GetCodeKind() const V8_OVERRIDE { return Code::LOAD_IC; }
@@ -1953,17 +1955,18 @@ class LoadICTrampolineStub : public PlatformCodeStub {
}
virtual ExtraICState GetExtraICState() const V8_FINAL V8_OVERRIDE {
- return state_.GetExtraICState();
+ return static_cast<ExtraICState>(minor_key_);
}
+ virtual Major MajorKey() const V8_OVERRIDE { return LoadICTrampoline; }
+
private:
- Major MajorKey() const { return LoadICTrampoline; }
- uint32_t MinorKey() const { return GetExtraICState(); }
+ LoadIC::State state() const {
+ return LoadIC::State(static_cast<ExtraICState>(minor_key_));
+ }
virtual void Generate(MacroAssembler* masm);
- const LoadIC::State state_;
-
DISALLOW_COPY_AND_ASSIGN(LoadICTrampolineStub);
};
@@ -1977,9 +1980,9 @@ class KeyedLoadICTrampolineStub : public LoadICTrampolineStub {
return Code::KEYED_LOAD_IC;
}
- private:
- Major MajorKey() const { return KeyedLoadICTrampoline; }
+ virtual Major MajorKey() const V8_OVERRIDE { return KeyedLoadICTrampoline; }
+ private:
virtual void Generate(MacroAssembler* masm);
DISALLOW_COPY_AND_ASSIGN(KeyedLoadICTrampolineStub);
@@ -2008,8 +2011,9 @@ class VectorLoadStub : public HydrogenCodeStub {
return state_.GetExtraICState();
}
+ virtual Major MajorKey() const V8_OVERRIDE { return VectorLoad; }
+
private:
- Major MajorKey() const { return VectorLoad; }
int NotMissMinorKey() const { return state_.GetExtraICState(); }
const LoadIC::State state_;
@@ -2034,9 +2038,9 @@ class VectorKeyedLoadStub : public VectorLoadStub {
return Code::KEYED_LOAD_IC;
}
- private:
- Major MajorKey() const { return VectorKeyedLoad; }
+ virtual Major MajorKey() const V8_OVERRIDE { return VectorKeyedLoad; }
+ private:
DISALLOW_COPY_AND_ASSIGN(VectorKeyedLoadStub);
};
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698