Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 500403002: Claim MPArch.* process management metrics. (Closed)

Created:
6 years, 3 months ago by ppi
Modified:
6 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Claim MPArch.* process management metrics. This patch sets ppi@ as owner of histograms tracking the child process launch time (important as this is a significant performance factor on some platforms) and number of renderer processes kept around. BUG=401821 Committed: https://crrev.com/eb340f90bc01d6ce3fc7df2d95cc2954ea256b45 Cr-Commit-Position: refs/heads/master@{#291918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ppi
ppi@chromium.org changed reviewers: + asvitkine@chromium.org
6 years, 3 months ago (2014-08-26 14:35:09 UTC) #1
ppi
Hi Alexei, ptal.
6 years, 3 months ago (2014-08-26 14:35:09 UTC) #2
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 3 months ago (2014-08-26 14:51:05 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-08-26 14:51:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/500403002/1
6 years, 3 months ago (2014-08-26 14:51:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 15:47:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 16:29:58 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 16:29:59 UTC) #8
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 3 months ago (2014-08-26 16:47:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/500403002/1
6 years, 3 months ago (2014-08-26 16:49:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (1) as 3710ac7153ce182cefea53b207903993c4bd7fdd
6 years, 3 months ago (2014-08-26 16:50:21 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb340f90bc01d6ce3fc7df2d95cc2954ea256b45
Cr-Commit-Position: refs/heads/master@{#291918}

Powered by Google App Engine
This is Rietveld 408576698