components/usb_service/usb_device_handle_impl.cc - Issue 500383003: Remove implicit conversions from scoped_refptr to T* in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/usb_service/usb_device_handle_impl.cc

Issue 500383003: Remove implicit conversions from scoped_refptr to T* in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/translate_download_manager.h ('k') | components/usb_service/usb_device_impl.cc » ('j') | components/webdata/common/web_database_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/usb_service/usb_device_handle_impl.cc

diff --git a/components/usb_service/usb_device_handle_impl.cc b/components/usb_service/usb_device_handle_impl.cc

index 71883177cad6c5c9b525273c8c6ba94edde928f8..73b04b95eb7f260121ce1255951c6998d4a9fcf6 100644

--- a/components/usb_service/usb_device_handle_impl.cc

+++ b/components/usb_service/usb_device_handle_impl.cc

@@ -196,7 +196,7 @@ UsbDeviceHandleImpl::UsbDeviceHandleImpl(

context_(context) {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(handle) << "Cannot create device with NULL handle.";

- DCHECK(interfaces_) << "Unable to list interfaces";

+ DCHECK(interfaces_.get()) << "Unable to list interfaces";

}

UsbDeviceHandleImpl::~UsbDeviceHandleImpl() {

@@ -532,7 +532,7 @@ void UsbDeviceHandleImpl::ControlTransfer(

const size_t resized_length = LIBUSB_CONTROL_SETUP_SIZE + length;

scoped_refptr<net::IOBuffer> resized_buffer(

new net::IOBufferWithSize(static_cast<int>(resized_length)));

- if (!resized_buffer) {

+ if (!resized_buffer.get()) {

callback.Run(USB_TRANSFER_ERROR, buffer, 0);

return;

}