Remove implicit conversions from scoped_refptr to T* in components/

components/webdata/common/web_database_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/webdata/common/web_database_service.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "components/webdata/common/web_data_request_manager.h"
 #include "components/webdata/common/web_data_results.h"
@@ skipping 38 matching lines @@
   // WebDatabaseService should be instantiated on UI thread.
   DCHECK(ui_thread->BelongsToCurrentThread());
   // WebDatabaseService requires DB thread if instantiated.
   DCHECK(db_thread.get());
 }
 
 WebDatabaseService::~WebDatabaseService() {
 }
 
 void WebDatabaseService::AddTable(scoped_ptr<WebDatabaseTable> table) {
-  if (!wds_backend_) {
+  if (!wds_backend_.get()) {
     wds_backend_ = new WebDataServiceBackend(
         path_, new BackendDelegate(weak_ptr_factory_.GetWeakPtr()),
         db_thread_);
   }
   wds_backend_->AddTable(table.Pass());
 }
 
 void WebDatabaseService::LoadDatabase() {
-  DCHECK(wds_backend_);
+  DCHECK(wds_backend_.get());
   db_thread_->PostTask(
       FROM_HERE,
       Bind(&WebDataServiceBackend::InitDatabase, wds_backend_));

[Cait (Slow), 2014/08/26 18:01:35]

Do scoped_refptr's in Bind() calls need to be made explicit as well?

If so, base::Bind examples
(https://code.google.com/p/chromium/codesearch#chromium/src/base/callback.h&l=70)
should probably be updated too.

[dcheng, 2014/08/26 18:09:38]

It depends on how it's being bound. In that particular exampe, it's OK--when
used as the object pointer, base::Bind() automatically saves a scoped_refptr
internally (if it's a ref counted class).

If passed as a parameter, then it depends on the callback definition--but in
that case, the tool will rewrite any parameters that need to be explicitly
converted with .get().

 }
 
 void WebDatabaseService::ShutdownDatabase() {
   db_loaded_ = false;
   loaded_callbacks_.clear();
   error_callbacks_.clear();
   weak_ptr_factory_.InvalidateWeakPtrs();
-  if (!wds_backend_)
+  if (!wds_backend_.get())
     return;
   db_thread_->PostTask(
       FROM_HERE, Bind(&WebDataServiceBackend::ShutdownDatabase, wds_backend_));
 }
 
 WebDatabase* WebDatabaseService::GetDatabaseOnDB() const {
   DCHECK(db_thread_->BelongsToCurrentThread());
-  return wds_backend_ ? wds_backend_->database() : NULL;
+  return wds_backend_.get() ? wds_backend_->database() : NULL;
 }
 
 scoped_refptr<WebDataServiceBackend> WebDatabaseService::GetBackend() const {
   return wds_backend_;
 }
 
 void WebDatabaseService::ScheduleDBTask(
     const tracked_objects::Location& from_here,
     const WriteTask& task) {
-  DCHECK(wds_backend_);
+  DCHECK(wds_backend_.get());
   scoped_ptr<WebDataRequest> request(
       new WebDataRequest(NULL, wds_backend_->request_manager().get()));
   db_thread_->PostTask(from_here,
                        Bind(&WebDataServiceBackend::DBWriteTaskWrapper,
                             wds_backend_, task, base::Passed(&request)));
 }
 
 WebDataServiceBase::Handle WebDatabaseService::ScheduleDBTaskWithResult(
     const tracked_objects::Location& from_here,
     const ReadTask& task,
     WebDataServiceConsumer* consumer) {
   DCHECK(consumer);
-  DCHECK(wds_backend_);
+  DCHECK(wds_backend_.get());
   scoped_ptr<WebDataRequest> request(
       new WebDataRequest(consumer, wds_backend_->request_manager().get()));
   WebDataServiceBase::Handle handle = request->GetHandle();
   db_thread_->PostTask(from_here,
                        Bind(&WebDataServiceBackend::DBReadTaskWrapper,
                             wds_backend_, task, base::Passed(&request)));
   return handle;
 }
 
 void WebDatabaseService::CancelRequest(WebDataServiceBase::Handle h) {
-  if (!wds_backend_)
+  if (!wds_backend_.get())
     return;
   wds_backend_->request_manager()->CancelRequest(h);
 }
 
 void WebDatabaseService::RegisterDBLoadedCallback(
     const DBLoadedCallback& callback) {
   loaded_callbacks_.push_back(callback);
 }
 
 void WebDatabaseService::RegisterDBErrorCallback(
@@ skipping 14 matching lines @@
   } else {
     // Notify that the database load failed.
     for (size_t i = 0; i < error_callbacks_.size(); i++) {
       if (!error_callbacks_[i].is_null())
         error_callbacks_[i].Run(status);
     }
 
     error_callbacks_.clear();
   }
 }