Fix for autofill bug 8627

Clicking a text field that is already focused triggers the autofill. However the code triggering this was just checking that the focused element before and after processing the event was the same.
We need to do a hit test to ensure the click is really on the text field, otherwise in cases where clicking somewhere in the page does not change the focus, we would bogusly bring up the autofill popup.

BUG=8627
TEST=Ensure autocomplete popup still works as expected: when  entering text, when using up/down arrows, when clicking selected text field. Also ensures the scenario from the bug does not trigger the popup.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12367

[eroman, 2009-03-20 00:34:25]

LGTM

feel free to commit with/without the nits.

http://codereview.chromium.org/50038/diff/1004/7
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/50038/diff/1004/7#newcode429
Line 429: EditorClientImpl::NodeToHTMLInputElement(focused_node.get())) {
I like the cleanups related to having these functions, but i'm not sure
EditorClientImpl is the best place to put them.

Perhaps declare in |dom_operations.h|?
(looking at dom_operations.cc there is some similarity, for example
GetNodeAsInputElement()).

Not a biggie, but something to think about :-)

http://codereview.chromium.org/50038/diff/1004/7#newcode432
Line 432: result =
page_->mainFrame()->eventHandler()->hitTestResultAtPoint(point,
this is good that you do the hit test before dispatching the mouse event (since
the event listener might move the field).

http://codereview.chromium.org/50038/diff/1004/7#newcode435
Line 435: // Already focused text field was clicked, let's remember this.  If
spelling: i think you want "lets" here.