Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 50034: Linux: optionally run <argv0>-renderer. (Closed)

Created:
11 years, 9 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: optionally run <argv0>-renderer. Ubuntu has AppArmor, which triggers based on binary names. Since we only want to sandbox the renderers they need to have a different name than the main Chromium binary (although it can just be a hard link to the same file). Thus, we probe to see if "<argv0>-renderer" exists. If so, we run that.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
11 years, 9 months ago (2009-03-19 22:02:14 UTC) #1
tony
11 years, 9 months ago (2009-03-19 22:20:52 UTC) #2
How hard is it to always have argv0-renderer?  It seems like even if the user
doesn't have AppArmor, we should still have the hardlinked chromium-renderer and
start that for renderer processes (easier to identify in ps and doesn't have to
check disk for the executable each time we want to start a renderer).

I imagine we need to update scons/gyp and the dpkg script.

Powered by Google App Engine
This is Rietveld 408576698