Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 500333002: Respect --profile-directory flag when used with --show-app-list flag. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
tapted, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Respect --profile-directory flag when used with --show-app-list flag. This CL allows specification of the profile to show the app list for when launching the app list via the command line. Currently --show-app-list always uses the last used app list profile, but we want to allow testers to more easily load the app list for a particular profile. On Windows, this can be used for making shorcuts to a particular profile's app list but this will always bind to the main shortcut due to the app id. BUG=400874 Committed: https://crrev.com/5814471fa14e46aacaf7bc61009aac89452ac400 Cr-Commit-Position: refs/heads/master@{#292291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
calamity
calamity@chromium.org changed reviewers: + tapted@chromium.org
6 years, 3 months ago (2014-08-26 05:11:30 UTC) #1
calamity
6 years, 3 months ago (2014-08-26 05:11:30 UTC) #2
tapted
lgtm - I would just add a bit more context to the CL description. Something ...
6 years, 3 months ago (2014-08-26 05:38:03 UTC) #3
calamity
On 2014/08/26 05:38:03, tapted wrote: > lgtm - I would just add a bit more ...
6 years, 3 months ago (2014-08-27 06:19:46 UTC) #4
calamity
calamity@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-27 06:20:03 UTC) #5
calamity
+sky for OWNERS.
6 years, 3 months ago (2014-08-27 06:20:03 UTC) #6
sky
LGTM
6 years, 3 months ago (2014-08-27 15:15:08 UTC) #7
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 3 months ago (2014-08-28 00:06:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/500333002/1
6 years, 3 months ago (2014-08-28 00:07:51 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:20:07 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:20:07 UTC) #11
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 3 months ago (2014-08-28 01:52:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/500333002/1
6 years, 3 months ago (2014-08-28 01:53:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as a97712ec2f7db8be779c09d3d0d037d6a6cba068
6 years, 3 months ago (2014-08-28 01:55:01 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5814471fa14e46aacaf7bc61009aac89452ac400
Cr-Commit-Position: refs/heads/master@{#292291}

Powered by Google App Engine
This is Rietveld 408576698