Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 500253003: Claim some localstorage histograms. (Closed)

Created:
6 years, 3 months ago by michaeln
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Claim some localstorage histograms. BUG=none NOTRY=true Committed: https://crrev.com/ec5c15f08d6a32a0ffc482bd786c338166cf9933 Cr-Commit-Position: refs/heads/master@{#291816}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 5 chunks +105 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (0 generated)
michaeln
michaeln@chromium.org changed reviewers: + isherman@chromium.org
6 years, 3 months ago (2014-08-25 23:02:19 UTC) #1
michaeln
ptal, these are being moved from the internal file and claimed
6 years, 3 months ago (2014-08-25 23:03:58 UTC) #2
Ilya Sherman
Could you please point me to a corresponding CL that removes these from the internal ...
6 years, 3 months ago (2014-08-25 23:19:46 UTC) #3
michaeln1
On 2014/08/25 23:19:46, Ilya Sherman wrote: > Could you please point me to a corresponding ...
6 years, 3 months ago (2014-08-25 23:59:00 UTC) #4
Ilya Sherman
https://codereview.chromium.org/500253003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/500253003/diff/1/tools/metrics/histograms/histograms.xml#newcode49010 tools/metrics/histograms/histograms.xml:49010: +</enum> It looks like you made some changes to ...
6 years, 3 months ago (2014-08-26 00:17:26 UTC) #5
michaeln
https://codereview.chromium.org/500253003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/500253003/diff/1/tools/metrics/histograms/histograms.xml#newcode49010 tools/metrics/histograms/histograms.xml:49010: +</enum> On 2014/08/26 00:17:26, Ilya Sherman wrote: > It ...
6 years, 3 months ago (2014-08-26 00:28:09 UTC) #6
Ilya Sherman
LGTM. Thanks!
6 years, 3 months ago (2014-08-26 00:28:46 UTC) #7
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 3 months ago (2014-08-26 00:32:03 UTC) #8
michaeln
The CQ bit was unchecked by michaeln@chromium.org
6 years, 3 months ago (2014-08-26 00:32:21 UTC) #9
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 3 months ago (2014-08-26 00:33:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/500253003/1
6 years, 3 months ago (2014-08-26 00:34:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (1) as ffd3aad3ed08f3f3f9ecb61a4ef029f9c4b1244b
6 years, 3 months ago (2014-08-26 00:47:05 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec5c15f08d6a32a0ffc482bd786c338166cf9933
Cr-Commit-Position: refs/heads/master@{#291816}

Powered by Google App Engine
This is Rietveld 408576698