Issue 500151: Remove two layout tests under chrome/fast/forms ; they've been obsoleted...

Issue 500151: Remove two layout tests under chrome/fast/forms ; they've been obsoleted... (Closed)

Created:
11 years ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove two layout tests under chrome/fast/forms ; they've been obsoleted by their upstream equivalents and I don't see any reason to keep them around. BUG=9161 BUG=11251 TEST=chrome/fast/forms/basic-textareas.html TEST=chrome/fast/forms/textarea-metrics.html R=ojan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35037

Patch Set 1 #

Patch Set 2 : don't remove FAIL expectation for fast/forms/basic-textareas; the test still fails #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2024 lines)			Patch
D	webkit/data/layout_tests/chrome/fast/forms/basic-textareas.html	View		1 chunk	+0 lines, -252 lines	0 comments	Download
D	webkit/data/layout_tests/chrome/fast/forms/textarea-metrics.html	View		1 chunk	+0 lines, -136 lines	0 comments	Download
D	webkit/data/layout_tests/chrome/fast/forms/textarea-metrics-expected.txt	View		1 chunk	+0 lines, -79 lines	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-linux/chrome/fast/forms/basic-textareas-expected.checksum	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-linux/chrome/fast/forms/basic-textareas-expected.png	View		Binary file		0 comments	Download
D	webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/basic-textareas-expected.checksum	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/basic-textareas-expected.png	View		Binary file		0 comments	Download
D	webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/basic-textareas-expected.txt	View		1 chunk	+0 lines, -672 lines	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/textarea-metrics-expected.txt	View		1 chunk	+0 lines, -79 lines	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.checksum	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.png	View		Binary file		0 comments	Download
D	webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.txt	View		1 chunk	+0 lines, -801 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

11 years ago (2009-12-19 02:10:49 UTC) #2

LGTM

On Fri, Dec 18, 2009 at 6:08 PM, <dpranke@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Remove two layout tests under chrome/fast/forms ; they've been obsoleted
> by their upstream equivalents and I don't see any reason to keep them
> around.
>
>  BUG=9161
>  BUG=11251
>  TEST=chrome/fast/forms/basic-textareas.html
>  TEST=chrome/fast/forms/textarea-metrics.html
>  R=ojan@chromium.org
>
>
> Please review this at http://codereview.chromium.org/500151
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  D     webkit/data/layout_tests/chrome/fast/forms/basic-textareas.html
>  D
> webkit/data/layout_tests/chrome/fast/forms/textarea-metrics-expected.txt
>  D     webkit/data/layout_tests/chrome/fast/forms/textarea-metrics.html
>  D
>
webkit/data/layout_tests/platform/chromium-linux/chrome/fast/forms/basic-textareas-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/chrome/fast/forms/basic-textareas-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/basic-textareas-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/basic-textareas-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/basic-textareas-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-mac/chrome/fast/forms/textarea-metrics-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/chrome/fast/forms/basic-textareas-expected.txt
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
>

Expand Messages | Collapse Messages