Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2568)

Unified Diff: chrome/browser/sessions/base_session_service.cc

Issue 500143002: Fixes possible use after free in SessionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweak Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/base_session_service.cc
diff --git a/chrome/browser/sessions/base_session_service.cc b/chrome/browser/sessions/base_session_service.cc
index a130c89d2ea517b6d5741a6d7af708539711a87e..c7e6e7a113e11e46034716340f85be04c9065a00 100644
--- a/chrome/browser/sessions/base_session_service.cc
+++ b/chrome/browser/sessions/base_session_service.cc
@@ -294,20 +294,17 @@ BaseSessionService::ScheduleGetLastSessionCommands(
return id;
}
-bool BaseSessionService::RunTaskOnBackendThread(
+void BaseSessionService::RunTaskOnBackendThread(
const tracked_objects::Location& from_here,
const base::Closure& task) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
if (!pool->IsShutdownInProgress()) {
- return pool->PostSequencedWorkerTask(sequence_token_,
- from_here,
- task);
+ pool->PostSequencedWorkerTask(sequence_token_, from_here, task);
} else {
// Fall back to executing on the main thread if the sequence
// worker pool has been requested to shutdown (around shutdown
// time).
task.Run();
- return true;
}
}

Powered by Google App Engine
This is Rietveld 408576698