Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 500133005: Fix broken path in GLES2 CTS. (Closed)

Created:
6 years, 3 months ago by Jamie Madill
Modified:
6 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix broken path in GLES2 CTS. AppendSwitch was casting all directories to lower case, causing the tests to early-out and return as always passed even before they create the test window. BUG=408251 Committed: https://crrev.com/62570ff8bf841529b61d542aa4d47586c80a4554 Cr-Commit-Position: refs/heads/master@{#292413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/gles2_conform_support/gles2_conform_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Jamie Madill
jmadill@chromium.org changed reviewers: + piman@chromium.org, sievers@chromium.org
6 years, 3 months ago (2014-08-27 20:52:54 UTC) #1
Jamie Madill
Please take a look. CC'ed Ken to keep tabs on this issue. This change will ...
6 years, 3 months ago (2014-08-27 20:53:51 UTC) #2
piman
lgtm
6 years, 3 months ago (2014-08-27 21:02:01 UTC) #3
Ken Russell (switch to Gerrit)
kbr@chromium.org changed reviewers: + kbr@chromium.org
6 years, 3 months ago (2014-08-27 21:59:16 UTC) #4
Ken Russell (switch to Gerrit)
Thank you for catching this. LGTM too.
6 years, 3 months ago (2014-08-27 21:59:16 UTC) #5
Jamie Madill
The CQ bit was checked by jmadill@chromium.org
6 years, 3 months ago (2014-08-28 13:29:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmadill@chromium.org/500133005/1
6 years, 3 months ago (2014-08-28 13:30:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5f92c71dfe6fd66d3ddf7e89e358e71e119c2331
6 years, 3 months ago (2014-08-28 18:19:37 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62570ff8bf841529b61d542aa4d47586c80a4554
Cr-Commit-Position: refs/heads/master@{#292413}

Powered by Google App Engine
This is Rietveld 408576698