Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 50013002: Get rid of two unused variables from the .data section. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com, bsalomon
Visibility:
Public.

Description

Get rid of two unused variables from the .data section. Before: $ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt 1 .data 00000000 0000000000000000 0000000000000000 000004ec 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000f58 2**2 0000000000000000 l d .data 0000000000000000 .data 2 .data 00000008 0000000000000000 0000000000000000 00001774 2**2 0000000000000000 l d .data 0000000000000000 .data 0000000000000000 g O .data 0000000000000004 debug_x 0000000000000004 g O .data 0000000000000004 debug_y 1 .data 00000000 0000000000000000 0000000000000000 00001d8c 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000054 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 000001f0 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000044 2**2 0000000000000000 l d .data 0000000000000000 .data After: $ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt 1 .data 00000000 0000000000000000 0000000000000000 000004ec 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000f58 2**2 0000000000000000 l d .data 0000000000000000 .data 2 .data 00000000 0000000000000000 0000000000000000 00001774 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00001d8c 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000054 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 000001f0 2**2 0000000000000000 l d .data 0000000000000000 .data 1 .data 00000000 0000000000000000 0000000000000000 00000044 2**2 0000000000000000 l d .data 0000000000000000 .data Not sure why clang didn't catch them. R=mtklein@google.com BUG= Committed: http://code.google.com/p/skia/source/detail?r=11999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/opts/SkBitmapFilter_opts_SSE2.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Is this OK/safe?
7 years, 1 month ago (2013-10-28 23:06:08 UTC) #1
mtklein
On 2013/10/28 23:06:08, tfarina wrote: > Is this OK/safe? lgtm I think Clang correctly ignores ...
7 years, 1 month ago (2013-10-29 15:03:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/50013002/1
7 years, 1 month ago (2013-10-29 15:08:54 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 15:32:12 UTC) #4
Message was sent while issue was closed.
Change committed as 11999

Powered by Google App Engine
This is Rietveld 408576698