cc/trees/thread_proxy.cc - Issue 500123003: Remove implicit conversions from scoped_refptr to T* in cc/trees/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/thread_proxy.cc

Issue 500123003: Remove implicit conversions from scoped_refptr to T* in cc/trees/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/thread_proxy.cc

diff --git a/cc/trees/thread_proxy.cc b/cc/trees/thread_proxy.cc

index 4a95140226db8fd2c72da44e632ebdd880bf1f5e..926884cba9c4fd3dc2ed40eb1d5102a0ea81f81b 100644

--- a/cc/trees/thread_proxy.cc

+++ b/cc/trees/thread_proxy.cc

@@ -1235,7 +1235,7 @@ void ThreadProxy::FinishGLOnImplThread(CompletionEvent* completion) {

TRACE_EVENT0("cc", "ThreadProxy::FinishGLOnImplThread");

DCHECK(IsImplThread());

if (impl().layer_tree_host_impl->output_surface()) {

- ContextProvider* context_provider =

+ scoped_refptr<ContextProvider> context_provider =

danakj 2014/08/25 20:25:01 can you just use .get() here? there's no need to t

dcheng 2014/08/25 20:56:58 Done (this was converted for the same reason).

impl().layer_tree_host_impl->output_surface()->context_provider();

if (context_provider)

context_provider->ContextGL()->Finish();

« cc/trees/layer_tree_impl.h ('K') | « cc/trees/layer_tree_impl.cc ('k') | cc/trees/tree_synchronizer_unittest.cc » ('j') | no next file with comments »