Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 500123002: Set WebURLResponse's URL in URLTestHelpers. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Set WebURLResponse's URL in URLTestHelpers. This is required in order to get the tests in the following CL to pass: https://codereview.chromium.org/295063002/ BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181220

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/testing/URLTestHelpers.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-08-25 16:16:34 UTC) #1
mlamouri (slow - plz ping)
Review ping. I believe this should be fairly straightforward.
6 years, 3 months ago (2014-08-27 17:14:21 UTC) #2
mlamouri (slow - plz ping)
+dcheng@, kennet.r.christiansen@ Could you have a look at this CL? This is required by https://codereview.chromium.org/295063002/ ...
6 years, 3 months ago (2014-09-02 00:10:48 UTC) #4
kenneth.christiansen
lgtm
6 years, 3 months ago (2014-09-02 08:47:30 UTC) #6
kenneth.r.christiansen
lgtm
6 years, 3 months ago (2014-09-02 08:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/500123002/20001
6 years, 3 months ago (2014-09-02 08:50:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 181220
6 years, 3 months ago (2014-09-02 08:55:06 UTC) #10
abarth-chromium
6 years, 3 months ago (2014-09-02 19:32:00 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698