src/utils/win/SkDWrite.h - Issue 500113002: Require length in sk_wchar_to_string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/win/SkDWrite.h

Issue 500113002: Require length in sk_wchar_to_string. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/win/SkDWrite.h

diff --git a/src/utils/win/SkDWrite.h b/src/utils/win/SkDWrite.h

index e763b4a0972fd89a31e06106d2da8ee46500be4b..123198ce5fe331acbd902f8a3edd2ad5c026e8e3 100644

--- a/src/utils/win/SkDWrite.h

+++ b/src/utils/win/SkDWrite.h

@@ -29,7 +29,7 @@ typedef SkAutoSTMalloc<16, WCHAR> SkSMallocWCHAR;

HRESULT sk_cstring_to_wchar(const char* skname, SkSMallocWCHAR* name);

/** Converts a WCHAR string to a utf8 string. */

-HRESULT sk_wchar_to_skstring(WCHAR* name, SkString* skname);

+HRESULT sk_wchar_to_skstring(WCHAR* name, int nameLen, SkString* skname);

reed1 2014/08/25 17:04:18 Can we document that nameLen is the number-of-WCHA

bungeman-skia 2014/08/25 17:08:52 Done.

////////////////////////////////////////////////////////////////////////////////

// Locale

« no previous file with comments | « src/ports/SkTypeface_win_dw.cpp ('k') | src/utils/win/SkDWrite.cpp » ('j') | no next file with comments »