Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 500108: Fix sync dialog cutting off on XP. (Closed)

Created:
11 years ago by chron_chromium.org
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix sync dialog wizard cutting off on XP in various languages. Fix sync dialog stop syncing dialog cutting off on XP in lang: ml. BUG=27770, 29767, 29788, 29782, 29647, 29767 TEST=Automated run through sync dialog and stop dialog.

Patch Set 1 #

Patch Set 2 : Fix for ML dialog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/app/resources/locale_settings_bn.xtb View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_de.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_el.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_fil.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_ml.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_ta.xtb View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_uk.xtb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
chron_chromium.org
I previously checked only on Vista, but I just rechecked XP as well. Should be ...
11 years ago (2009-12-17 20:42:15 UTC) #1
chron_chromium.org
11 years ago (2009-12-17 22:47:26 UTC) #2
Zachary Kuznia
LGTM
11 years ago (2009-12-17 23:26:03 UTC) #3
tim (not reviewing)
11 years ago (2009-12-18 18:46:30 UTC) #4
On 2009/12/17 23:26:03, zork wrote:
> LGTM

rubber stamp lgtm

Powered by Google App Engine
This is Rietveld 408576698