Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 500093002: Use border-box sizing for the HR element. (Closed)

Created:
6 years, 4 months ago by rhogan
Modified:
5 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use border-box sizing for the HR element. This matches Firefox's UA stylesheet. BUG=17217 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193582

Patch Set 1 #

Patch Set 2 : Updated Expectations #

Patch Set 3 : Updated #

Patch Set 4 : Updated #

Patch Set 5 : Updated #

Patch Set 6 : Updated #

Patch Set 7 : Updated #

Patch Set 8 : Updated #

Patch Set 9 : Updated #

Patch Set 10 : Updated #

Patch Set 11 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -67 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 3 chunks +43 lines, -5 lines 0 comments Download
A LayoutTests/fast/block/hr-border-box-sizing.html View 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/hr-border-box-sizing-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/block/basic/018-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/block/basic/018-expected.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/fast/block/float/025-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/block/float/026-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/block/float/027-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/block/float/028-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/block/float/float-avoidance-expected.txt View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1067-2-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1067-2-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1188-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1188-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug14323-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug14323-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug14929-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug14929-expected.txt View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1800-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1800-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug32841-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug32841-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug33137-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug33137-expected.txt View 1 2 3 4 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug42187-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug42187-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug47432-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug47432-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug60992-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug60992-expected.txt View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug625-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug625-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug727-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug727-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/col_widths_fix_autoFix-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/col_widths_fix_autoFix-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/col_widths_fix_fix-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/col_widths_fix_fix-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/misc-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/misc-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/table_widths-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/core/table_widths-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/97619-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/97619-expected.txt View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug1647-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug1647-expected.txt View 1 2 3 4 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/core/col_span2-expected.txt View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/core/conflicts-expected.png View 1 2 3 4 Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/core/conflicts-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/other/empty_cells-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/html.css View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
rhogan
6 years ago (2014-12-10 19:07:29 UTC) #2
leviw_travelin_and_unemployed
lgtm
5 years, 8 months ago (2015-04-08 18:37:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/500093002/140001
5 years, 8 months ago (2015-04-08 21:42:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/500093002/180001
5 years, 8 months ago (2015-04-09 18:10:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/58590)
5 years, 8 months ago (2015-04-09 22:04:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/500093002/200001
5 years, 8 months ago (2015-04-10 22:27:34 UTC) #14
commit-bot: I haz the power
Committed patchset #11 (id:200001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193582
5 years, 8 months ago (2015-04-11 01:05:12 UTC) #15
myakura
5 years, 7 months ago (2015-05-12 05:08:37 UTC) #16
Message was sent while issue was closed.
On 2015/04/08 at 18:37:01, leviw wrote:
> lgtm

hmm. the spec does not suggest hr to be border-box (
https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2 ).

it looks only Gecko uses border-box
(https://github.com/necolas/normalize.css/blob/master/normalize.css#L208-L215) .
do we really want the defaut style to change?

Powered by Google App Engine
This is Rietveld 408576698