Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: chrome/browser/debugger/devtools_window.h

Issue 50009: Allow different types of devtools client (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_view.cc ('k') | chrome/browser/debugger/devtools_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_window.h
===================================================================
--- chrome/browser/debugger/devtools_window.h (revision 12273)
+++ chrome/browser/debugger/devtools_window.h (working copy)
@@ -6,32 +6,29 @@
#define CHROME_BROWSER_DEBUGGER_DEV_TOOLS_WINDOW_H_
#include "base/basictypes.h"
+#include "chrome/browser/debugger/devtools_client_host.h"
-class DevToolsInstanceDescriptor;
+class RenderViewHost;
-class DevToolsWindow {
+class DevToolsWindow : public DevToolsClientHost {
public:
- static DevToolsWindow* Create(DevToolsInstanceDescriptor* descriptor);
+ // Factory method for creating platform specific devtools windows.
+ static DevToolsWindow* Create();
+
virtual ~DevToolsWindow() {}
- // Show developer tools window.
+ // Show this window.
virtual void Show() = 0;
- virtual void Close() = 0;
+ virtual bool HasRenderViewHost(const RenderViewHost& rvh) const = 0;
+ // DevToolsClientHost override.
+ virtual DevToolsWindow* AsDevToolsWindow() { return this; }
+
protected:
- DevToolsWindow() {}
+ DevToolsWindow() : DevToolsClientHost() {}
private:
DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
};
-// Factory for creating DevToolsWindows. Useful for unit tests.
-class DevToolsWindowFactory {
- public:
- virtual ~DevToolsWindowFactory() {}
- virtual DevToolsWindow* CreateDevToolsWindow(
- DevToolsInstanceDescriptor* descriptor) = 0;
-};
-
-
#endif // CHROME_BROWSER_DEBUGGER_DEV_TOOLS_WINDOW_H_
« no previous file with comments | « chrome/browser/debugger/devtools_view.cc ('k') | chrome/browser/debugger/devtools_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698