Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: chrome/browser/debugger/devtools_window_win.cc

Issue 50009: Allow different types of devtools client (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_window_win.h ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_window_win.cc
===================================================================
--- chrome/browser/debugger/devtools_window_win.cc (revision 12273)
+++ chrome/browser/debugger/devtools_window_win.cc (working copy)
@@ -6,20 +6,21 @@
#include "chrome/browser/debugger/devtools_manager.h"
#include "chrome/browser/debugger/devtools_view.h"
+#include "chrome/browser/debugger/devtools_window.h"
#include "chrome/views/window/window.h"
// static
-DevToolsWindow* DevToolsWindow::Create(DevToolsInstanceDescriptor* descriptor) {
- DevToolsView* view = new DevToolsView(descriptor);
+DevToolsWindow* DevToolsWindow::Create() {
+ DevToolsView* view = new DevToolsView();
DevToolsWindowWin* window = new DevToolsWindowWin(view);
- descriptor->SetDevToolsWindow(window);
views::Window::CreateChromeWindow(NULL, gfx::Rect(), window);
return window;
}
DevToolsWindowWin::DevToolsWindowWin(DevToolsView* view)
- : tools_view_(view) {
+ : DevToolsWindow(),
+ tools_view_(view) {
}
DevToolsWindowWin::~DevToolsWindowWin() {
@@ -34,7 +35,14 @@
}
}
-void DevToolsWindowWin::Close() {
+bool DevToolsWindowWin::HasRenderViewHost(const RenderViewHost& rvh) const {
+ if (tools_view_) {
+ return tools_view_->HasRenderViewHost(rvh);
+ }
+ return false;
+}
+
+void DevToolsWindowWin::InspectedTabClosing() {
if (window()) {
window()->Close();
} else {
@@ -42,12 +50,20 @@
}
}
+void DevToolsWindowWin::SendMessageToClient(const IPC::Message& message) {
+ if (tools_view_) {
+ tools_view_->SendMessageToClient(message);
+ }
+}
+
std::wstring DevToolsWindowWin::GetWindowTitle() const {
return L"Developer Tools";
}
void DevToolsWindowWin::WindowClosing() {
if (tools_view_) {
+ NotifyCloseListener();
+
ReleaseWindow();
tools_view_->OnWindowClosing();
tools_view_ = NULL;
« no previous file with comments | « chrome/browser/debugger/devtools_window_win.h ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698