Add PolicyProvider to ExtensionManagement

chrome/browser/extensions/extension_management.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
+#include "base/bind.h"
+#include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/extensions/external_provider_impl.h"
+#include "chrome/browser/extensions/standard_management_policy_provider.h"
+#include "chrome/browser/profiles/profile.h"
 #include "components/crx_file/id_util.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "extensions/browser/pref_names.h"
 #include "extensions/common/url_pattern.h"
 
 namespace extensions {
 
 void ExtensionManagement::IndividualSettings::Reset() {
   installation_mode = ExtensionManagement::INSTALLATION_ALLOWED;
   update_url.clear();
 }
 
 ExtensionManagement::GlobalSettings::GlobalSettings() {
 }
 
 ExtensionManagement::GlobalSettings::~GlobalSettings() {
 }
 
 void ExtensionManagement::GlobalSettings::Reset() {
   has_restricted_install_sources = false;
   install_sources.ClearPatterns();
   has_restricted_allowed_types = false;
   allowed_types.clear();
 }
 
 ExtensionManagement::ExtensionManagement(PrefService* pref_service)
     : pref_service_(pref_service) {
+  pref_change_registrar_.Init(pref_service_);
+  pref_change_registrar_.Add(
+      pref_names::kInstallAllowList,
+      base::Bind(&ExtensionManagement::OnExtensionPrefChanged,
+                 base::Unretained(this)));
+  pref_change_registrar_.Add(
+      pref_names::kInstallDenyList,
+      base::Bind(&ExtensionManagement::OnExtensionPrefChanged,
+                 base::Unretained(this)));
+  pref_change_registrar_.Add(
+      pref_names::kInstallForceList,
+      base::Bind(&ExtensionManagement::OnExtensionPrefChanged,
+                 base::Unretained(this)));
+  pref_change_registrar_.Add(
+      pref_names::kAllowedInstallSites,
+      base::Bind(&ExtensionManagement::OnExtensionPrefChanged,
+                 base::Unretained(this)));
+  pref_change_registrar_.Add(
+      pref_names::kAllowedTypes,
+      base::Bind(&ExtensionManagement::OnExtensionPrefChanged,
+                 base::Unretained(this)));

[Joao da Silva, 2014/09/03 11:52:54]

Suggestion: all of these registrations use the same callback function. Instead
of creating 5 base::Callbacks with base::Bind, create just 1 and share it with
the registrations.

(base::Callbacks can be copied cheaply since they share the internal storage,
but calling base::Bind 5 times won't share those internal structures)

[binjin, 2014/09/03 15:31:36]

Done.

+  Refresh();
+  provider_.reset(new StandardManagementPolicyProvider(this));
 }
 
 ExtensionManagement::~ExtensionManagement() {
 }
 
+void ExtensionManagement::AddObserver(Observer* obs) {
+  observer_list_.AddObserver(obs);
+}
+
+void ExtensionManagement::RemoveObserver(Observer* obs) {

[Joao da Silva, 2014/09/03 11:52:54]

Rename "obs" to "observer"

[binjin, 2014/09/03 15:31:36]

Done.

+  observer_list_.RemoveObserver(obs);
+}
+
+ManagementPolicy::Provider* ExtensionManagement::GetProvider() {
+  return provider_.get();
+}
+
+bool ExtensionManagement::BlacklistedByDefault() {
+  return default_settings_.installation_mode == INSTALLATION_BLOCKED;
+}
+
+const ExtensionManagement::IndividualSettings& ExtensionManagement::ReadById(
+    const ExtensionId& id) const {
+  DCHECK(crx_file::id_util::IdIsValid(id)) << "Invalid ID: " << id;
+  SettingsIdMap::const_iterator it = settings_by_id_.find(id);
+  if (it != settings_by_id_.end())
+    return it->second;
+  return default_settings_;
+}
+
+const ExtensionManagement::GlobalSettings&
+ExtensionManagement::ReadGlobalSettings() const {
+  return global_settings_;
+}
+
 void ExtensionManagement::Refresh() {
   // Load all extension management settings preferences.
   const base::ListValue* allowed_list_pref =
       static_cast<const base::ListValue*>(LoadPreference(
           pref_names::kInstallAllowList, true, base::Value::TYPE_LIST));
   const base::ListValue* denied_list_pref =
       static_cast<const base::ListValue*>(LoadPreference(
           pref_names::kInstallDenyList, false, base::Value::TYPE_LIST));
   const base::DictionaryValue* forced_list_pref =
       static_cast<const base::DictionaryValue*>(LoadPreference(
@@ skipping 80 matching lines @@
         global_settings_.allowed_types.push_back(
             static_cast<Manifest::Type>(int_value));
       }
     }
   }
 
   // TODO(binjin): Add parsing of new ExtensionManagement preference after the
   // new ExtensionManagement policy is added.
 }
 
-const ExtensionManagement::IndividualSettings& ExtensionManagement::ReadById(
-    const ExtensionId& id) const {
-  DCHECK(crx_file::id_util::IdIsValid(id)) << "Invalid ID: " << id;
-  SettingsIdMap::const_iterator it = settings_by_id_.find(id);
-  if (it != settings_by_id_.end())
-    return it->second;
-  return default_settings_;
-}
-
-const ExtensionManagement::GlobalSettings&
-ExtensionManagement::ReadGlobalSettings() const {
-  return global_settings_;
-}
-
 const base::Value* ExtensionManagement::LoadPreference(
     const char* pref_name,
     bool force_managed,
     base::Value::Type expected_type) {
   const PrefService::Preference* pref =
       pref_service_->FindPreference(pref_name);
   if (pref && !pref->IsDefaultValue() &&
       (!force_managed || pref->IsManaged())) {
     const base::Value* value = pref->GetValue();
     if (value && value->IsType(expected_type))
       return value;
   }
   return NULL;
 }
 
+void ExtensionManagement::OnExtensionPrefChanged() {
+  Refresh();
+  NotifyExtensionManagementPrefChanged();
+}
+
+void ExtensionManagement::NotifyExtensionManagementPrefChanged() {
+  FOR_EACH_OBSERVER(
+      Observer, observer_list_, OnExtensionManagementPrefChanged());
+}
+
 ExtensionManagement::IndividualSettings* ExtensionManagement::AccessById(
     const ExtensionId& id) {
   DCHECK(crx_file::id_util::IdIsValid(id)) << "Invalid ID: " << id;
   SettingsIdMap::iterator it = settings_by_id_.find(id);
   if (it == settings_by_id_.end())
     it = settings_by_id_.insert(std::make_pair(id, default_settings_)).first;
   return &it->second;
 }
 
+ExtensionManagement* ExtensionManagementFactory::GetForBrowserContext(
+    content::BrowserContext* context) {
+  return static_cast<ExtensionManagement*>(
+      GetInstance()->GetServiceForBrowserContext(context, true));
+}
+
+ExtensionManagementFactory* ExtensionManagementFactory::GetInstance() {
+  return Singleton<ExtensionManagementFactory>::get();
+}
+
+ExtensionManagementFactory::ExtensionManagementFactory()
+    : BrowserContextKeyedServiceFactory(
+          "ExtensionManagement",
+          BrowserContextDependencyManager::GetInstance()) {
+}
+
+ExtensionManagementFactory::~ExtensionManagementFactory() {
+}
+
+KeyedService* ExtensionManagementFactory::BuildServiceInstanceFor(
+    content::BrowserContext* context) const {
+  return new ExtensionManagement(
+      Profile::FromBrowserContext(context)->GetPrefs());
+}
+
 }  // namespace extensions