Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 500033003: Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. (Closed)

Created:
6 years, 4 months ago by Finnur
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. (patchset #2 of https://codereview.chromium.org/254713004/) Reason for revert: Still failing: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/52254/steps/content_browsertests/logs/CanMakeEmptyCallThenAddStreamsAndRenegotiate Original issue's description: > Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. > The underalying problem is now fixed. See http://crbug/293125 and https://code.google.com/p/webrtc/source/detail?r=5870 > > BUG=293125, 362431 > > Committed: https://chromium.googlesource.com/chromium/src/+/b9a00c2caf679dfd2e97a3d6bbfd5e214609e1fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Finnur
Created Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again.
6 years, 4 months ago (2014-08-25 12:02:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/500033003/1
6 years, 4 months ago (2014-08-25 12:02:57 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 12:02:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-25 12:02:58 UTC) #4
pauljensen
6 years, 4 months ago (2014-08-25 12:36:34 UTC) #5
Finnur, I created my own revert CL as your's got stuck while you were at lunch. 
Feel free to close this one.

Powered by Google App Engine
This is Rietveld 408576698