Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 50003: Should only create one downloads tab per window. Introducing another window disposition (Closed)

Created:
11 years, 9 months ago by Mohamed Mansour (USE mhm)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Should only create one downloads tab per window. If there is already a Downloads tab, then switch to it instead of creating new one. This would be similar to the way Ctrl+J works. As well, a FOCUS_SINGLETON_TAB disposition was implemented in which is a great feature to have, in case we would like to just open one tab. BUG=8767 ( http://crbug.com/8767 )

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/browser.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/download/download_shelf.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/window_open_disposition.h View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mohamed Mansour (USE mhm)
New build (using latest svn)
11 years, 9 months ago (2009-03-19 06:28:13 UTC) #1
Evan Stade
CCed Ben. LGTM. Could you delete the second paragraph of the change description? http://codereview.chromium.org/50003/diff/1/5 File ...
11 years, 9 months ago (2009-03-19 18:32:00 UTC) #2
Mohamed Mansour (USE mhm)
On 2009/03/19 18:32:00, estade wrote: > CCed Ben. > > LGTM. Could you delete the ...
11 years, 9 months ago (2009-03-19 18:36:46 UTC) #3
Ben Goodger (Google)
+CC pkasting, who was involved in the WindowOpenDisposition stuff and may have an opinion.
11 years, 9 months ago (2009-03-22 21:09:58 UTC) #4
Peter Kasting
I haven't really been paying attention; my only comment is that "SINGLETON_TAB" seems like a ...
11 years, 9 months ago (2009-03-23 00:49:42 UTC) #5
Peter Kasting
Oh, also: Be careful when adding this. Audit existing code, not just in browser/ but ...
11 years, 9 months ago (2009-03-23 00:50:37 UTC) #6
Mohamed Mansour (USE mhm)
done. I have checked the glue layer, afaik, the only thing needed is that open ...
11 years, 9 months ago (2009-03-23 05:11:28 UTC) #7
Mohamed Mansour (USE mhm)
Could someone commit this?
11 years, 9 months ago (2009-03-27 21:40:19 UTC) #8
Evan Stade
11 years, 8 months ago (2009-04-02 22:31:07 UTC) #9
committed in r13045

Powered by Google App Engine
This is Rietveld 408576698