Issue 500023004: Revert a mistake in Node::CollectProjections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500023004: Revert a mistake in Node::CollectProjections. (Closed)

Created:
6 years, 4 months ago by Jarin

Modified:
6 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert a mistake in Node::CollectProjections. Fix for a bug I introduced in r23270. BUG= R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23360

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/compiler/instruction-selector.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/compiler/node.cc	View		1 chunk	+8 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm with comment https://codereview.chromium.org/500023004/diff/1/src/compiler/node.cc File src/compiler/node.cc (right): https://codereview.chromium.org/500023004/diff/1/src/compiler/node.cc#newcode15 src/compiler/node.cc:15: (*projections)[i] = NULL; I think you ...

6 years, 4 months ago (2014-08-25 13:17:13 UTC) #2

Jarin

6 years, 4 months ago (2014-08-25 14:28:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23360 (presubmit successful).

Expand Messages | Collapse Messages