Teach v8rel script to read git hashes from DEPS.

Teach v8rel script to read git hashes from DEPS.

The chromium DEPS file can refer to v8 git hashes now. These
are converted back into svn revision numbers for the v8
releases spreadsheet.

The DEPS file's quotation mark policy changed which affects
the regexp for retrieving the v8 revision ("->').

TEST=script_test.py
TEST=tools/push-to-trunk/releases.py -c /path/to/chromium/src --branch recent
R=hinoka@google.com

Committed: https://code.google.com/p/v8/source/detail?r=23357

[Michael Achenbach, 2014-08-25 12:14:34]

PTAL. Code partially borrowed from roll-dep from depot_tools.

[Ryan Tseng, 2014-08-25 13:19:17]

lgtm % comments

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
File tools/push-to-trunk/releases.py (right):

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:50: DEPS_RE =
re.compile('^\\s*(?:(?:"|\')v8_revision(?:"|\'): (?:"|\')'
running regex on the DEPS file? :/

you can use r"""...""" to continue to do raw strings.

also i think ['"] works in place of (?:"|')

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:378: if len(revision) > 6:
Reversing this make more sense

if revision.isdigit() and len(revision) < 8:
  return revision

...{return git-svn}...

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:382: os.chdir(os.path.join(step["chrome_path"],
"v8"))
I don't really like this, but seeing how the rest of the file uses this
convention it might be a lost cause...

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:406: self.GitFetchOrigin()
You might have to either (1) rebase on current branch or (2) ensure
origin/master is checked out.

Unless you're just updating the clone to get the git-svn numbers, and not
fetching to get V8 HEAD, in which case ignore this comment.

[Michael Achenbach, 2014-08-25 13:32:52]

Done.

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
File tools/push-to-trunk/releases.py (right):

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:50: DEPS_RE =
re.compile('^\\s*(?:(?:"|\')v8_revision(?:"|\'): (?:"|\')'
On 2014/08/25 13:19:17, Ryan T. (EMEA time) wrote:
> running regex on the DEPS file? :/
> 
> you can use r"""...""" to continue to do raw strings.
> 
> also i think ['"] works in place of (?:"|')

The """ is good to know, thanks!

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:378: if len(revision) > 6:
On 2014/08/25 13:19:17, Ryan T. (EMEA time) wrote:
> Reversing this make more sense
> 
> if revision.isdigit() and len(revision) < 8:
>   return revision
> 
> ...{return git-svn}...

Done.

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:382: os.chdir(os.path.join(step["chrome_path"],
"v8"))
On 2014/08/25 13:19:17, Ryan T. (EMEA time) wrote:
> I don't really like this, but seeing how the rest of the file uses this
> convention it might be a lost cause...

Most of this/these files originated from some old bash scripts and were
transformed to python line by line :/ These are the relics of it.

https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/rele...
tools/push-to-trunk/releases.py:406: self.GitFetchOrigin()
On 2014/08/25 13:19:17, Ryan T. (EMEA time) wrote:
> You might have to either (1) rebase on current branch or (2) ensure
> origin/master is checked out.
> 
> Unless you're just updating the clone to get the git-svn numbers, and not
> fetching to get V8 HEAD, in which case ignore this comment.

Just reading the svn numbers.

[Michael Achenbach, 2014-08-25 13:39:50]

Committed patchset #2 manually as 23357 (tree was closed).