Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5045)

Unified Diff: chrome/browser/autocomplete/base_search_provider.h

Issue 500023002: Introduce AutocompleteProviderDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.h
diff --git a/chrome/browser/autocomplete/base_search_provider.h b/chrome/browser/autocomplete/base_search_provider.h
index fbcebc7c5a735af98457f2790aea9b19ac72427d..477da0a81474895c6edee6f0d1875c8b067f95d3 100644
--- a/chrome/browser/autocomplete/base_search_provider.h
+++ b/chrome/browser/autocomplete/base_search_provider.h
@@ -22,8 +22,8 @@
#include "components/omnibox/autocomplete_provider.h"
#include "components/omnibox/search_suggestion_parser.h"
+class AutocompleteProviderDelegate;
class GURL;
-class Profile;
class SearchTermsData;
class SuggestionDeletionHandler;
class TemplateURL;
@@ -50,7 +50,7 @@ class BaseSearchProvider : public AutocompleteProvider {
static const int kDeletionURLFetcherID;
BaseSearchProvider(TemplateURLService* template_url_service,
- Profile* profile,
+ scoped_ptr<AutocompleteProviderDelegate> delegate,
AutocompleteProvider::Type type);
// Returns whether |match| is flagged as a query that should be prefetched.
@@ -145,7 +145,7 @@ class BaseSearchProvider : public AutocompleteProvider {
const TemplateURL* template_url,
metrics::OmniboxEventProto::PageClassification page_classification,
const SearchTermsData& search_terms_data,
- Profile* profile);
+ AutocompleteProviderDelegate* delegate);
// Returns whether we can send the URL of the current page in any suggest
// requests. Doing this requires that all the following hold:
@@ -169,7 +169,7 @@ class BaseSearchProvider : public AutocompleteProvider {
const TemplateURL* template_url,
metrics::OmniboxEventProto::PageClassification page_classification,
const SearchTermsData& search_terms_data,
- Profile* profile);
+ AutocompleteProviderDelegate* delegate);
// If the |deletion_url| is valid, then set |match.deletable| to true and
// save the |deletion_url| into the |match|'s additional info under
@@ -221,7 +221,7 @@ class BaseSearchProvider : public AutocompleteProvider {
virtual void RecordDeletionResult(bool success) = 0;
TemplateURLService* template_url_service_;
- Profile* profile_;
+ scoped_ptr<AutocompleteProviderDelegate> delegate_;
// Whether a field trial, if any, has triggered in the most recent
// autocomplete query. This field is set to true only if the suggestion

Powered by Google App Engine
This is Rietveld 408576698