Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 500023002: Introduce AutocompleteProviderDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/zero_suggest_provider.h" 5 #include "chrome/browser/autocomplete/zero_suggest_provider.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/i18n/case_conversion.h" 8 #include "base/i18n/case_conversion.h"
9 #include "base/json/json_string_value_serializer.h" 9 #include "base/json/json_string_value_serializer.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/metrics/user_metrics.h" 11 #include "base/metrics/user_metrics.h"
12 #include "base/prefs/pref_service.h" 12 #include "base/prefs/pref_service.h"
13 #include "base/strings/string16.h" 13 #include "base/strings/string16.h"
14 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "base/time/time.h" 16 #include "base/time/time.h"
17 #include "chrome/browser/autocomplete/autocomplete_classifier.h" 17 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
18 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" 18 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
19 #include "chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.h"
19 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h" 20 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
20 #include "chrome/browser/autocomplete/history_url_provider.h" 21 #include "chrome/browser/autocomplete/history_url_provider.h"
21 #include "chrome/browser/autocomplete/search_provider.h" 22 #include "chrome/browser/autocomplete/search_provider.h"
22 #include "chrome/browser/history/history_types.h" 23 #include "chrome/browser/history/history_types.h"
23 #include "chrome/browser/history/top_sites.h" 24 #include "chrome/browser/history/top_sites.h"
24 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/common/pref_names.h" 26 #include "chrome/common/pref_names.h"
26 #include "components/metrics/proto/omnibox_input_type.pb.h" 27 #include "components/metrics/proto/omnibox_input_type.pb.h"
27 #include "components/omnibox/autocomplete_input.h" 28 #include "components/omnibox/autocomplete_input.h"
28 #include "components/omnibox/autocomplete_match.h" 29 #include "components/omnibox/autocomplete_match.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 base::string16 prefix; 112 base::string16 prefix;
112 TemplateURLRef::SearchTermsArgs search_term_args(prefix); 113 TemplateURLRef::SearchTermsArgs search_term_args(prefix);
113 GURL suggest_url(default_provider->suggestions_url_ref().ReplaceSearchTerms( 114 GURL suggest_url(default_provider->suggestions_url_ref().ReplaceSearchTerms(
114 search_term_args, template_url_service_->search_terms_data())); 115 search_term_args, template_url_service_->search_terms_data()));
115 if (!suggest_url.is_valid()) 116 if (!suggest_url.is_valid())
116 return; 117 return;
117 118
118 // No need to send the current page URL in personalized suggest field trial. 119 // No need to send the current page URL in personalized suggest field trial.
119 if (CanSendURL(input.current_url(), suggest_url, default_provider, 120 if (CanSendURL(input.current_url(), suggest_url, default_provider,
120 current_page_classification_, 121 current_page_classification_,
121 template_url_service_->search_terms_data(), profile_) && 122 template_url_service_->search_terms_data(), delegate_.get()) &&
122 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) { 123 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) {
123 // Update suggest_url to include the current_page_url. 124 // Update suggest_url to include the current_page_url.
124 search_term_args.current_page_url = current_query_; 125 search_term_args.current_page_url = current_query_;
125 suggest_url = GURL(default_provider->suggestions_url_ref(). 126 suggest_url = GURL(default_provider->suggestions_url_ref().
126 ReplaceSearchTerms( 127 ReplaceSearchTerms(
127 search_term_args, 128 search_term_args,
128 template_url_service_->search_terms_data())); 129 template_url_service_->search_terms_data()));
129 } else if (!CanShowZeroSuggestWithoutSendingURL(suggest_url, 130 } else if (!CanShowZeroSuggestWithoutSendingURL(suggest_url,
130 input.current_url())) { 131 input.current_url())) {
131 return; 132 return;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // The user has started editing in the omnibox, so leave 177 // The user has started editing in the omnibox, so leave
177 // |field_trial_triggered_in_session_| unchanged and set 178 // |field_trial_triggered_in_session_| unchanged and set
178 // |field_trial_triggered_| to false since zero suggest is inactive now. 179 // |field_trial_triggered_| to false since zero suggest is inactive now.
179 field_trial_triggered_ = false; 180 field_trial_triggered_ = false;
180 } 181 }
181 182
182 ZeroSuggestProvider::ZeroSuggestProvider( 183 ZeroSuggestProvider::ZeroSuggestProvider(
183 AutocompleteProviderListener* listener, 184 AutocompleteProviderListener* listener,
184 TemplateURLService* template_url_service, 185 TemplateURLService* template_url_service,
185 Profile* profile) 186 Profile* profile)
186 : BaseSearchProvider(template_url_service, profile, 187 : BaseSearchProvider(template_url_service,
188 scoped_ptr<AutocompleteProviderDelegate>(
189 new ChromeAutocompleteProviderDelegate(profile)),
187 AutocompleteProvider::TYPE_ZERO_SUGGEST), 190 AutocompleteProvider::TYPE_ZERO_SUGGEST),
188 listener_(listener), 191 listener_(listener),
192 profile_(profile),
189 results_from_cache_(false), 193 results_from_cache_(false),
190 weak_ptr_factory_(this) { 194 weak_ptr_factory_(this) {
191 } 195 }
192 196
193 ZeroSuggestProvider::~ZeroSuggestProvider() { 197 ZeroSuggestProvider::~ZeroSuggestProvider() {
194 } 198 }
195 199
196 const TemplateURL* ZeroSuggestProvider::GetTemplateURL(bool is_keyword) const { 200 const TemplateURL* ZeroSuggestProvider::GetTemplateURL(bool is_keyword) const {
197 // Zero suggest provider should not receive keyword results. 201 // Zero suggest provider should not receive keyword results.
198 DCHECK(!is_keyword); 202 DCHECK(!is_keyword);
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 return results_.verbatim_relevance >= 0 ? 423 return results_.verbatim_relevance >= 0 ?
420 results_.verbatim_relevance : kDefaultVerbatimZeroSuggestRelevance; 424 results_.verbatim_relevance : kDefaultVerbatimZeroSuggestRelevance;
421 } 425 }
422 426
423 bool ZeroSuggestProvider::CanShowZeroSuggestWithoutSendingURL( 427 bool ZeroSuggestProvider::CanShowZeroSuggestWithoutSendingURL(
424 const GURL& suggest_url, 428 const GURL& suggest_url,
425 const GURL& current_page_url) const { 429 const GURL& current_page_url) const {
426 if (!ZeroSuggestEnabled(suggest_url, 430 if (!ZeroSuggestEnabled(suggest_url,
427 template_url_service_->GetDefaultSearchProvider(), 431 template_url_service_->GetDefaultSearchProvider(),
428 current_page_classification_, 432 current_page_classification_,
429 template_url_service_->search_terms_data(), profile_)) 433 template_url_service_->search_terms_data(),
434 delegate_.get()))
430 return false; 435 return false;
431 436
432 // If we cannot send URLs, then only the MostVisited and Personalized 437 // If we cannot send URLs, then only the MostVisited and Personalized
433 // variations can be shown. 438 // variations can be shown.
434 if (!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial() && 439 if (!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial() &&
435 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) 440 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial())
436 return false; 441 return false;
437 442
438 // Only show zero suggest for HTTP[S] pages. 443 // Only show zero suggest for HTTP[S] pages.
439 // TODO(mariakhomenko): We may be able to expand this set to include pages 444 // TODO(mariakhomenko): We may be able to expand this set to include pages
(...skipping 16 matching lines...) Expand all
456 if (!json_data.empty()) { 461 if (!json_data.empty()) {
457 scoped_ptr<base::Value> data( 462 scoped_ptr<base::Value> data(
458 SearchSuggestionParser::DeserializeJsonData(json_data)); 463 SearchSuggestionParser::DeserializeJsonData(json_data));
459 if (data && ParseSuggestResults( 464 if (data && ParseSuggestResults(
460 *data, kDefaultZeroSuggestRelevance, false, &results_)) { 465 *data, kDefaultZeroSuggestRelevance, false, &results_)) {
461 ConvertResultsToAutocompleteMatches(); 466 ConvertResultsToAutocompleteMatches();
462 results_from_cache_ = !matches_.empty(); 467 results_from_cache_ = !matches_.empty();
463 } 468 }
464 } 469 }
465 } 470 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698