Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 500013002: Drop 64 character limit in DeviceManagementRequest |agent| parameter (Closed)

Created:
6 years, 4 months ago by bartfab (slow)
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Drop 64 character limit in DeviceManagementRequest |agent| parameter The HTTP POST |agent| parameter sent with a DeviceManagementRequest is limited to 64 characters. After the git migration, Chrome includes its git revision in the |agent|, making it longer than 64 characters. This CL removes the arbitrary 64 character limit. This solution should be considered temporary, until we have verified that the DMServer can handle |agents| longer than 64 characters. If not, we will restore this limit and change the construction of the string so that it never exceeds 64 characters. BUG=406948 TEST=Browser tests no longer fail when the |agent| string is too long Committed: https://crrev.com/a4b8fb8fdb4580f847e54e1e59419aa8182809e7 Cr-Commit-Position: refs/heads/master@{#291672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/policy/test/policy_testserver.py View 1 chunk +1 line, -2 lines 0 comments Download
M components/policy/proto/device_management_backend.proto View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Joao, Could you take a look? This will de-flake the tests. I started a ...
6 years, 4 months ago (2014-08-25 09:45:37 UTC) #1
Joao da Silva
lgtm
6 years, 4 months ago (2014-08-25 11:36:03 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 4 months ago (2014-08-25 11:45:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/500013002/1
6 years, 4 months ago (2014-08-25 11:45:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 9ff894fcfee224effd2ecd5421ec851ede32efba
6 years, 4 months ago (2014-08-25 12:37:43 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4b8fb8fdb4580f847e54e1e59419aa8182809e7
Cr-Commit-Position: refs/heads/master@{#291672}

Powered by Google App Engine
This is Rietveld 408576698