Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 499933002: Simplify SMILTime operators (Closed)

Created:
6 years, 4 months ago by reni
Modified:
6 years, 3 months ago
Reviewers:
fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Simplify SMILTime operators Since the unresolved and indefined symbols are represented by NaN and Inf values already, the SMILTime operators can be simplified. R=fs@opera.com BUG=406899 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180925

Patch Set 1 #

Patch Set 2 : Move +/- operators to the header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M Source/core/svg/animation/SMILTime.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SMILTime.cpp View 1 1 chunk +2 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reni
6 years, 4 months ago (2014-08-24 11:40:51 UTC) #1
fs
LGTM Suggest that the definitions of operator+ and operator- is moved to the header (and ...
6 years, 4 months ago (2014-08-25 15:06:08 UTC) #2
reni
The CQ bit was checked by rhodovan.u-szeged@partner.samsung.com
6 years, 3 months ago (2014-08-26 20:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/499933002/20001
6 years, 3 months ago (2014-08-26 20:34:09 UTC) #4
reni
On 2014/08/25 15:06:08, fs (ooo) wrote: > LGTM > > Suggest that the definitions of ...
6 years, 3 months ago (2014-08-26 20:36:32 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 23:54:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180925

Powered by Google App Engine
This is Rietveld 408576698