Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
49983003:
Roll Clang 192869:193323 (Closed)
|
Created:
7 years, 1 month ago by hans Modified:
7 years, 1 month ago Reviewers:
Nico CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionRoll Clang 192869:193323
BUG=313468, 313823
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233418
Patch Set 1 #Patch Set 2 : Use rm -rf for *.dylib #
Total comments: 1
Patch Set 3 : Rebase #Messages
Total messages: 19 (0 generated)
I think trybots look about as good as they usually do (compared to whitespace change here: https://codereview.chromium.org/53673002/#ps1)
lgtm https://codereview.chromium.org/49983003/diff/150001/tools/clang/scripts/upda... File tools/clang/scripts/update.sh (right): https://codereview.chromium.org/49983003/diff/150001/tools/clang/scripts/upda... tools/clang/scripts/update.sh:144: find "${DIR}" -name '*.dylib' -exec rm -rf {} + why is this needed?
On 2013/10/31 18:11:43, Nico wrote: > lgtm > > https://codereview.chromium.org/49983003/diff/150001/tools/clang/scripts/upda... > File tools/clang/scripts/update.sh (right): > > https://codereview.chromium.org/49983003/diff/150001/tools/clang/scripts/upda... > tools/clang/scripts/update.sh:144: find "${DIR}" -name '*.dylib' -exec rm -rf {} > + > why is this needed? The mac_rel trybots were failing during the "Clobber the build files" step. mmoss looked at the bot and said: 09:36 < mmoss> there are some dirs (no longer generated or needed) that seem to be causing update problems on macs 09:37 < mmoss> http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/183132... 09:38 < mmoss> the actual error is: 09:38 < mmoss> rm: src/tools/clang/scripts/../../../out/Debug/content_shell.syms/libwtf.dylib: is a directory 09:38 < mmoss> (many times) So it seems .dylib's are sometimes dirs?
On Thu, Oct 31, 2013 at 11:28 AM, <hans@chromium.org> wrote: > On 2013/10/31 18:11:43, Nico wrote: > >> lgtm >> > > > https://codereview.chromium.**org/49983003/diff/150001/** > tools/clang/scripts/update.sh<https://codereview.chromium.org/49983003/diff/150001/tools/clang/scripts/update.sh> > >> File tools/clang/scripts/update.sh (right): >> > > > https://codereview.chromium.**org/49983003/diff/150001/** > tools/clang/scripts/update.sh#**newcode144<https://codereview.chromium.org/49983003/diff/150001/tools/clang/scripts/update.sh#newcode144> > >> tools/clang/scripts/update.sh:**144: find "${DIR}" -name '*.dylib' -exec >> rm -rf >> > {} > >> + >> why is this needed? >> > > The mac_rel trybots were failing during the "Clobber the build files" step. > mmoss looked at the bot and said: > > 09:36 < mmoss> there are some dirs (no longer generated or needed) that > seem to > be causing update problems on macs > 09:37 < mmoss> > http://build.chromium.org/p/**tryserver.chromium/builders/** > mac_rel/builds/183132/steps/**runhooks/logs/stdio<http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/183132/steps/runhooks/logs/stdio> > 09:38 < mmoss> the actual error is: > 09:38 < mmoss> rm: > src/tools/clang/scripts/../../**../out/Debug/content_shell.**syms/libwtf.dylib: > is > a directory > 09:38 < mmoss> (many times) > > So it seems .dylib's are sometimes dirs? > That sounds like a serious bug :-( Can you file this please? > > https://codereview.chromium.**org/49983003/<https://codereview.chromium.org/4... > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2013/10/31 18:38:08, Nico wrote:
> >> tools/clang/scripts/update.sh:**144: find "${DIR}" -name '*.dylib' -exec
> >> rm -rf
> >>
> > {}
> >
> >> +
> >> why is this needed?
> >>
> >
> > The mac_rel trybots were failing during the "Clobber the build files" step.
> > mmoss looked at the bot and said:
> >
> > 09:36 < mmoss> there are some dirs (no longer generated or needed) that
> > seem to
> > be causing update problems on macs
> > 09:37 < mmoss>
> > http://build.chromium.org/p/**tryserver.chromium/builders/**
> >
>
mac_rel/builds/183132/steps/**runhooks/logs/stdio<http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/183132/steps/runhooks/logs/stdio>
> > 09:38 < mmoss> the actual error is:
> > 09:38 < mmoss> rm:
> >
>
src/tools/clang/scripts/../../**../out/Debug/content_shell.**syms/libwtf.dylib:
> > is
> > a directory
> > 09:38 < mmoss> (many times)
> >
> > So it seems .dylib's are sometimes dirs?
> >
>
> That sounds like a serious bug :-( Can you file this please?
Filed crbug.com/313823
Do you think the "rm -rf" change is OK, or should we wait?
I think it's ok for now. If it's just the symbols stuff, it's just somewhat surprising and less scary. Please add that other bug to the BUG= line.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/150001
Step "update" is always a major failure. Look at the try server FAQ for more details. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/150001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/150001
Message was sent while issue was closed.
Change committed as 232260
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/480001
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/480001
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/480001
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/49983003/480001
Message was sent while issue was closed.
Change committed as 233418 |
