Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 499823002: Fix compilation with Ozone build for chromium browser. (Closed)

Created:
6 years, 4 months ago by kalyank
Modified:
6 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix compilation with Ozone build for chromium browser. Compiling Error: ../../chrome/browser/shell_integration_linux.cc:294:13: error: unused function 'QuoteCommandLineForDesktopFileExec' [-Werror,-Wunused-function] std::string QuoteCommandLineForDesktopFileExec( ^ ../../chrome/browser/shell_integration_linux.cc:310:12: error: unused variable 'kDesktopEntry' [-Werror,-Wunused-const-variable] const char kDesktopEntry[] = "Desktop Entry"; ^ ../../chrome/browser/shell_integration_linux.cc:312:12: error: unused variable 'kXdgOpenShebang' [-Werror,-Wunused-const-variable] const char kXdgOpenShebang[] = "#!/usr/bin/env xdg-open"; ^ 3 errors generated. The above mentioned function and variables are only used from GetNoDisplayFromDesktopFile, only when support for GLIB is enabled. Committed: https://crrev.com/577803cd5ac9c7e65cb39f4b18688ff841e82500 Cr-Commit-Position: refs/heads/master@{#291748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/shell_integration_linux.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kalyank
6 years, 4 months ago (2014-08-23 05:51:48 UTC) #1
Elliot Glaysher
lgtm
6 years, 3 months ago (2014-08-25 17:47:51 UTC) #2
kalyank
The CQ bit was checked by kalyan.kondapally@intel.com
6 years, 3 months ago (2014-08-25 19:18:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/499823002/1
6 years, 3 months ago (2014-08-25 19:18:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as ddabac49de70dc97602c1acae1e579db0bfce043
6 years, 3 months ago (2014-08-25 20:13:54 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/577803cd5ac9c7e65cb39f4b18688ff841e82500
Cr-Commit-Position: refs/heads/master@{#291748}

Powered by Google App Engine
This is Rietveld 408576698