Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 499813002: Update AuraWindowRegistry to create only positive window IDs. (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Update AuraWindowRegistry to create only positive window IDs. Previously AuraWindowRegistry was allocating ID 0 to first window. This breaks assumptions made in other places, e.g. DCHECK in DesktopMediaPickerDialogView. After this change the implementation guarantees that window IDs are always unique positive integers. Committed: https://crrev.com/fc74c509cd0575563483e5f6b1bd5fd930754bd5 Cr-Commit-Position: refs/heads/master@{#291708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/public/browser/desktop_media_id.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
6 years, 4 months ago (2014-08-23 01:26:03 UTC) #1
jam
lgtm
6 years, 3 months ago (2014-08-25 02:06:28 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 3 months ago (2014-08-25 16:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/499813002/60001
6 years, 3 months ago (2014-08-25 16:38:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (60001) as 3d1f35cecc24b6c6d0ef0826edcad70312d7d859
6 years, 3 months ago (2014-08-25 17:46:28 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc74c509cd0575563483e5f6b1bd5fd930754bd5
Cr-Commit-Position: refs/heads/master@{#291708}

Powered by Google App Engine
This is Rietveld 408576698