Restrict windows dead zone revisions from bisect.

Restrict windows dead zone revisions from bisect.

BUG=405274
NOTRY=true

[qyearsley, 2014-08-23 00:31:38]

On 2014/08/23 00:00:12, prasadv wrote:

lgtm

[prasadv, 2014-08-23 00:32:31]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2014-08-23 04:56:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/499753002/1

[commit-bot: I haz the power, 2014-08-23 22:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-23 22:10:02]

Failed to apply patch for tools/bisect-perf-regression.py:
While running git apply --index -p1;
  error: patch failed: tools/bisect-perf-regression.py:2240
  error: tools/bisect-perf-regression.py: patch does not apply

Patch:       tools/bisect-perf-regression.py
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index
993947a3ce6ce2614f7b5171253eb565534aa852..8f7afcfa4ef02e03e27ef46f29bf1fc16f9d693b
100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -2240,23 +2240,25 @@ class BisectPerformanceMetrics(object):
       # Cros/svn use integers
       return int(good_revision) <= int(bad_revision)
 
-  def CanPerformBisect(self, revision_to_check):
+  def CanPerformBisect(self, good_revision, bad_revision):
     """Checks whether a given revision is bisectable.
 
-    Note: At present it checks whether a given revision is bisectable on
-    android bots(refer crbug.com/385324).
+    Checks for following:
+    1. Non-bisectable revsions for android bots (refer to crbug.com/385324).
+    2. Non-bisectable revsions for Windows bots (refer to crbug.com/405274).
 
     Args:
-      revision_to_check: Known good revision.
+      good_revision: Known good revision.
+      bad_revision: Known bad revision.
 
     Returns:
       A dictionary indicating the result. If revision is not bisectable,
       this will contain the field "error", otherwise None.
     """
     if self.opts.target_platform == 'android':
-      revision_to_check = self.source_control.SVNFindRev(revision_to_check)
-      if (bisect_utils.IsStringInt(revision_to_check)
-          and revision_to_check < 265549):
+      good_revision = self.source_control.SVNFindRev(good_revision)
+      if (bisect_utils.IsStringInt(good_revision)
+          and good_revision < 265549):
         return {'error': (
             'Bisect cannot conitnue for the given revision range.\n'
             'It is impossible to bisect Android regressions '
@@ -2264,6 +2266,18 @@ class BisectPerformanceMetrics(object):
             'rely on Telemetry to do apk installation of the most recently '
             'built local ChromeShell(refer to crbug.com/385324).\n'
             'Please try bisecting revisions greater than or equal to
r265549.')}
+
+    if bisect_utils.IsWindowsHost():
+      good_revision = self.source_control.SVNFindRev(good_revision)
+      bad_revision = self.source_control.SVNFindRev(bad_revision)
+      if (bisect_utils.IsStringInt(good_revision) and
+          bisect_utils.IsStringInt(bad_revision)):
+        if (289987 <= good_revision < 290716 or
+            289987 <= bad_revision < 290716):
+          return {'error': ('Oops! Revision between r289987 and r290716 are '
+                            'marked as dead zone for Windows due to '
+                            'crbug.com/405274. Please try another range.')}
+
     return None
 
   def Run(self, command_to_run, bad_revision_in, good_revision_in, metric):
@@ -2353,7 +2367,7 @@ class BisectPerformanceMetrics(object):
     if self.opts.output_buildbot_annotations:
       bisect_utils.OutputAnnotationStepStart('Gathering Revisions')
 
-    cannot_bisect = self.CanPerformBisect(good_revision)
+    cannot_bisect = self.CanPerformBisect(good_revision, bad_revision)
     if cannot_bisect:
       results['error'] = cannot_bisect.get('error')
       return results

[prasadv, 2014-08-25 16:15:50]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2014-08-25 16:16:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/499753002/1

[commit-bot: I haz the power, 2014-08-25 16:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 16:16:58]

Failed to apply patch for tools/bisect-perf-regression.py:
While running git apply --index -p1;
  error: patch failed: tools/bisect-perf-regression.py:2240
  error: tools/bisect-perf-regression.py: patch does not apply

Patch:       tools/bisect-perf-regression.py
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index
993947a3ce6ce2614f7b5171253eb565534aa852..8f7afcfa4ef02e03e27ef46f29bf1fc16f9d693b
100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -2240,23 +2240,25 @@ class BisectPerformanceMetrics(object):
       # Cros/svn use integers
       return int(good_revision) <= int(bad_revision)
 
-  def CanPerformBisect(self, revision_to_check):
+  def CanPerformBisect(self, good_revision, bad_revision):
     """Checks whether a given revision is bisectable.
 
-    Note: At present it checks whether a given revision is bisectable on
-    android bots(refer crbug.com/385324).
+    Checks for following:
+    1. Non-bisectable revsions for android bots (refer to crbug.com/385324).
+    2. Non-bisectable revsions for Windows bots (refer to crbug.com/405274).
 
     Args:
-      revision_to_check: Known good revision.
+      good_revision: Known good revision.
+      bad_revision: Known bad revision.
 
     Returns:
       A dictionary indicating the result. If revision is not bisectable,
       this will contain the field "error", otherwise None.
     """
     if self.opts.target_platform == 'android':
-      revision_to_check = self.source_control.SVNFindRev(revision_to_check)
-      if (bisect_utils.IsStringInt(revision_to_check)
-          and revision_to_check < 265549):
+      good_revision = self.source_control.SVNFindRev(good_revision)
+      if (bisect_utils.IsStringInt(good_revision)
+          and good_revision < 265549):
         return {'error': (
             'Bisect cannot conitnue for the given revision range.\n'
             'It is impossible to bisect Android regressions '
@@ -2264,6 +2266,18 @@ class BisectPerformanceMetrics(object):
             'rely on Telemetry to do apk installation of the most recently '
             'built local ChromeShell(refer to crbug.com/385324).\n'
             'Please try bisecting revisions greater than or equal to
r265549.')}
+
+    if bisect_utils.IsWindowsHost():
+      good_revision = self.source_control.SVNFindRev(good_revision)
+      bad_revision = self.source_control.SVNFindRev(bad_revision)
+      if (bisect_utils.IsStringInt(good_revision) and
+          bisect_utils.IsStringInt(bad_revision)):
+        if (289987 <= good_revision < 290716 or
+            289987 <= bad_revision < 290716):
+          return {'error': ('Oops! Revision between r289987 and r290716 are '
+                            'marked as dead zone for Windows due to '
+                            'crbug.com/405274. Please try another range.')}
+
     return None
 
   def Run(self, command_to_run, bad_revision_in, good_revision_in, metric):
@@ -2353,7 +2367,7 @@ class BisectPerformanceMetrics(object):
     if self.opts.output_buildbot_annotations:
       bisect_utils.OutputAnnotationStepStart('Gathering Revisions')
 
-    cannot_bisect = self.CanPerformBisect(good_revision)
+    cannot_bisect = self.CanPerformBisect(good_revision, bad_revision)
     if cannot_bisect:
       results['error'] = cannot_bisect.get('error')
       return results

[prasadv, 2014-09-03 16:55:02]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2014-09-03 16:56:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/499753002/1

[commit-bot: I haz the power, 2014-09-03 16:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 16:58:21]

Failed to apply patch for tools/bisect-perf-regression.py:
While running git apply --index -p1;
  error: patch failed: tools/bisect-perf-regression.py:2240
  error: tools/bisect-perf-regression.py: patch does not apply

Patch:       tools/bisect-perf-regression.py
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index
993947a3ce6ce2614f7b5171253eb565534aa852..8f7afcfa4ef02e03e27ef46f29bf1fc16f9d693b
100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -2240,23 +2240,25 @@ class BisectPerformanceMetrics(object):
       # Cros/svn use integers
       return int(good_revision) <= int(bad_revision)
 
-  def CanPerformBisect(self, revision_to_check):
+  def CanPerformBisect(self, good_revision, bad_revision):
     """Checks whether a given revision is bisectable.
 
-    Note: At present it checks whether a given revision is bisectable on
-    android bots(refer crbug.com/385324).
+    Checks for following:
+    1. Non-bisectable revsions for android bots (refer to crbug.com/385324).
+    2. Non-bisectable revsions for Windows bots (refer to crbug.com/405274).
 
     Args:
-      revision_to_check: Known good revision.
+      good_revision: Known good revision.
+      bad_revision: Known bad revision.
 
     Returns:
       A dictionary indicating the result. If revision is not bisectable,
       this will contain the field "error", otherwise None.
     """
     if self.opts.target_platform == 'android':
-      revision_to_check = self.source_control.SVNFindRev(revision_to_check)
-      if (bisect_utils.IsStringInt(revision_to_check)
-          and revision_to_check < 265549):
+      good_revision = self.source_control.SVNFindRev(good_revision)
+      if (bisect_utils.IsStringInt(good_revision)
+          and good_revision < 265549):
         return {'error': (
             'Bisect cannot conitnue for the given revision range.\n'
             'It is impossible to bisect Android regressions '
@@ -2264,6 +2266,18 @@ class BisectPerformanceMetrics(object):
             'rely on Telemetry to do apk installation of the most recently '
             'built local ChromeShell(refer to crbug.com/385324).\n'
             'Please try bisecting revisions greater than or equal to
r265549.')}
+
+    if bisect_utils.IsWindowsHost():
+      good_revision = self.source_control.SVNFindRev(good_revision)
+      bad_revision = self.source_control.SVNFindRev(bad_revision)
+      if (bisect_utils.IsStringInt(good_revision) and
+          bisect_utils.IsStringInt(bad_revision)):
+        if (289987 <= good_revision < 290716 or
+            289987 <= bad_revision < 290716):
+          return {'error': ('Oops! Revision between r289987 and r290716 are '
+                            'marked as dead zone for Windows due to '
+                            'crbug.com/405274. Please try another range.')}
+
     return None
 
   def Run(self, command_to_run, bad_revision_in, good_revision_in, metric):
@@ -2353,7 +2367,7 @@ class BisectPerformanceMetrics(object):
     if self.opts.output_buildbot_annotations:
       bisect_utils.OutputAnnotationStepStart('Gathering Revisions')
 
-    cannot_bisect = self.CanPerformBisect(good_revision)
+    cannot_bisect = self.CanPerformBisect(good_revision, bad_revision)
     if cannot_bisect:
       results['error'] = cannot_bisect.get('error')
       return results

[qyearsley, 2014-09-03 17:57:39]

On 2014/09/03 16:58:21, I haz the power (commit-bot) wrote:
> Failed to apply patch for tools/bisect-perf-regression.py:
> While running git apply --index -p1;
>   error: patch failed: tools/bisect-perf-regression.py:2240
>   error: tools/bisect-perf-regression.py: patch does not apply

Needs rebasing?