Fixed javascript_dialog_manager to compile when extensions are disabled.

chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/i18n/rtl.h"
 #include "base/memory/singleton.h"
@@ skipping 40 matching lines @@
 #else
   return NULL;
 #endif  // defined(ENABLE_EXTENSIONS)
 }
 
 // Keeps an |extension| from shutting down its lazy background page. If an
 // extension opens a dialog its lazy background page must stay alive until the
 // dialog closes.
 void IncrementLazyKeepaliveCount(const Extension* extension,
                                  WebContents* web_contents) {
+#if defined(ENABLE_EXTENSIONS)
   DCHECK(extension);
   DCHECK(web_contents);
   extensions::ProcessManager* pm = GetExtensionsProcessManager(web_contents);
   if (pm)
     pm->IncrementLazyKeepaliveCount(extension);
+#endif  // defined(ENABLE_EXTENSIONS)

[msw, 2014/08/22 22:21:50]

nit: "// ENABLE_EXTENSIONS" would follow the more common general commenting
pattern for pre-processor block termination. That said, apparently this
particular pre-processor definition more commonly follows your pattern here.

[David Yen, 2014/08/22 22:28:25]

Done. I went ahead and fixed all the other #endif // defined(ENABLE_EXTENSIONS)"
in this file to match the general pattern.

 }
 
 // Allows an |extension| to shut down its lazy background page after a dialog
 // closes (if nothing else is keeping it open).
 void DecrementLazyKeepaliveCount(const Extension* extension,
                                  WebContents* web_contents) {
+#if defined(ENABLE_EXTENSIONS)
   DCHECK(extension);
   DCHECK(web_contents);
   extensions::ProcessManager* pm = GetExtensionsProcessManager(web_contents);
   if (pm)
     pm->DecrementLazyKeepaliveCount(extension);
+#endif  // defined(ENABLE_EXTENSIONS)
 }
 
 class ChromeJavaScriptDialogManager : public JavaScriptDialogManager {
  public:
   static ChromeJavaScriptDialogManager* GetInstance();
 
   virtual void RunJavaScriptDialog(
       WebContents* web_contents,
       const GURL& origin_url,
       const std::string& accept_lang,
@@ skipping 226 matching lines @@
     DecrementLazyKeepaliveCount(extension, web_contents);
 
   callback.Run(success, user_input);
 }
 
 }  // namespace
 
 content::JavaScriptDialogManager* GetJavaScriptDialogManagerInstance() {
   return ChromeJavaScriptDialogManager::GetInstance();
 }