Don't pass buffers to HidConnection::Read because it knows the size.

device/hid/hid_connection_win.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_HID_HID_CONNECTION_WIN_H_
 #define DEVICE_HID_HID_CONNECTION_WIN_H_
 
 #include <windows.h>
 
 #include <set>
 
 #include "base/win/scoped_handle.h"
 #include "device/hid/hid_connection.h"
 
 namespace device {
 
 struct PendingHidTransfer;
 
 class HidConnectionWin : public HidConnection {
  public:
   explicit HidConnectionWin(const HidDeviceInfo& device_info);
 
   // HidConnection implementation.

[Ken Rockot(use gerrit already), 2014/08/26 16:32:04]

nit: Might as well make the Platform* methods private all around, yeah? They
should only be called by HidConnection.

[Reilly Grant (use Gerrit), 2014/08/26 17:17:22]

Done.

-  virtual void PlatformRead(scoped_refptr<net::IOBufferWithSize> buffer,
-                            const IOCallback& callback) OVERRIDE;
-  virtual void PlatformWrite(uint8_t report_id,
-                             scoped_refptr<net::IOBufferWithSize> buffer,
-                             const IOCallback& callback) OVERRIDE;
-  virtual void PlatformGetFeatureReport(
-      uint8_t report_id,
-      scoped_refptr<net::IOBufferWithSize> buffer,
-      const IOCallback& callback) OVERRIDE;
+  virtual void PlatformRead(const ReadCallback& callback) OVERRIDE;
+  virtual void PlatformWrite(scoped_refptr<net::IOBuffer> buffer,
+                             size_t size,
+                             const WriteCallback& callback) OVERRIDE;
+  virtual void PlatformGetFeatureReport(uint8_t report_id,
+                                        const ReadCallback& callback) OVERRIDE;
   virtual void PlatformSendFeatureReport(
-      uint8_t report_id,
-      scoped_refptr<net::IOBufferWithSize> buffer,
-      const IOCallback& callback) OVERRIDE;
+      scoped_refptr<net::IOBuffer> buffer,
+      size_t size,
+      const WriteCallback& callback) OVERRIDE;
 
  private:
   friend class HidServiceWin;
   friend struct PendingHidTransfer;
 
   ~HidConnectionWin();
 
   bool available() const { return file_.IsValid(); }
 
-  void OnTransferFinished(scoped_refptr<PendingHidTransfer> transfer);
-  void OnTransferCanceled(scoped_refptr<PendingHidTransfer> transfer);
+  void OnReadComplete(scoped_refptr<net::IOBuffer> buffer,
+                      const ReadCallback& callback,
+                      PendingHidTransfer* transfer,
+                      bool signaled);
+  void OnReadFeatureComplete(scoped_refptr<net::IOBuffer> buffer,
+                             const ReadCallback& callback,
+                             PendingHidTransfer* transfer,
+                             bool signaled);
+  void OnWriteComplete(const WriteCallback& callback,
+                       PendingHidTransfer* transfer,
+                       bool signaled);
 
   base::win::ScopedHandle file_;
 
   std::set<scoped_refptr<PendingHidTransfer> > transfers_;
 
   DISALLOW_COPY_AND_ASSIGN(HidConnectionWin);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_HID_HID_CONNECTION_WIN_H_