Issue 499643002: Convert SimpleStringDictionary interface documentation to Doxygen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 499643002: Convert SimpleStringDictionary interface documentation to Doxygen (Closed)

Created:
6 years, 4 months ago by Mark Mentovai

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Convert SimpleStringDictionary interface documentation to Doxygen. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d0fcfa42e485

Patch Set 2 : Address review feedback #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -39 lines)			Patch
	M	client/simple_string_dictionary.h	View	1	10 chunks	+67 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM https://codereview.chromium.org/499643002/diff/1/client/simple_string_dictionary.h File client/simple_string_dictionary.h (right): https://codereview.chromium.org/499643002/diff/1/client/simple_string_dictionary.h#newcode33 client/simple_string_dictionary.h:33: // !

6 years, 4 months ago (2014-08-22 21:05:24 UTC) #2

Mark Mentovai

6 years, 4 months ago (2014-08-22 21:09:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as d0fcfa42e485 (presubmit successful).

Expand Messages | Collapse Messages

Issue 499643002: Convert SimpleStringDictionary interface documentation to Doxygen (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review feedback #

Messages