Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 499633002: Componentize component_updater: Copy over test data with executable bit. (Closed)

Created:
6 years, 4 months ago by tommycli
Modified:
6 years, 4 months ago
Reviewers:
waffles, Evan Stade
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Componentize component_updater: Copy over test data with executable bit. As part of making component_updater a component, we are now moving over all the tests. Before we do that, we're copying the test data over. We are deleting it from the original spot in a separate CL. This patch will need to be dcommitted, since component1.dll file is executable bit, and CQ chokes on that. Review of this change is here: https://codereview.chromium.org/497803002/ BUG=371463 R=waffles@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291490

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
tommycli
estade: This is the patch I mentioned on IRC that has the executable bit file ...
6 years, 4 months ago (2014-08-22 18:16:06 UTC) #1
waffles
lgtm for move - sheriff can approve dcommmit
6 years, 4 months ago (2014-08-22 19:44:52 UTC) #2
tommycli
6 years, 4 months ago (2014-08-22 20:12:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 291490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698