Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 499623002: Instrument DomDistiller with timing information. (Closed)

Created:
6 years, 4 months ago by Yaron
Modified:
6 years, 4 months ago
Reviewers:
cjhopman
CC:
kuan, nyquist
Base URL:
https://code.google.com/p/dom-distiller/@master
Visibility:
Public.

Description

Instrument DomDistiller with timing information. Introduces a TimingInfo message as part of the DomDistiller response which includes timing breakdown of the various phases of processing as well as total time. Refactored ContentExtractor to break the phases down into smaller steps and changed TextDocument to be the carrier of information accross phases of processing. R=cjhopman@chromium.org Committed: 0cc1705

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -26 lines) Patch
M proto/dom_distiller.proto View 1 chunk +9 lines, -0 lines 0 comments Download
M src/com/dom_distiller/client/ContentExtractor.java View 4 chunks +76 lines, -21 lines 0 comments Download
M src/com/dom_distiller/client/DomDistiller.java View 3 chunks +5 lines, -3 lines 0 comments Download
M src/com/dom_distiller/client/DomUtil.java View 1 chunk +5 lines, -0 lines 0 comments Download
M src/de/l3s/boilerpipe/document/TextDocument.java View 3 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yaron
6 years, 4 months ago (2014-08-22 18:03:39 UTC) #1
cjhopman
lgtm
6 years, 4 months ago (2014-08-23 00:25:06 UTC) #2
Yaron
6 years, 4 months ago (2014-08-25 15:55:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 0cc1705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698