LayoutTests/media/video-buffered-unknown-duration.html - Issue 499513002: Add layout test and test media for infinite duration tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-buffered-unknown-duration.html

Issue 499513002: Add layout test and test media for infinite duration tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body onload="start()">

	4 <p>Load a video with an infinite duration. Start playback and ensure

	5 video.currentTime < video.buffered.end(0) upon first timeupdate.</p>

	6 <video preload></video>
	scherkus (not reviewing) 2014/08/22 02:38:41 nit: drop preload attribute altogether (absence is nit: drop preload attribute altogether (absence is still treated as auto) DaleCurtis 2014/08/22 19:40:29 Done. Show quoted text On 2014/08/22 02:38:41, scherkus wrote: > nit: drop preload attribute altogether (absence is still treated as auto) Done.
	7 <script src="video-test.js"></script>

	8 <script src="media-file.js"></script>

	9 <script>

	10 waitForEventOnce('timeupdate', function() {

	11 video.pause();

	12

	13 testExpected('video.duration', Infinity, '==');

	14 testExpected('video.buffered.start(0)', 0, '>=');

	15

	16 // 10 seconds chosen arbitrarily as it's larger than the duration, but

	17 // small enough to test for overflow of arithmetic performed on the

	18 // infinite duration.

	19 testExpected('video.buffered.end(0)', 10, '<');
	scherkus (not reviewing) 2014/08/22 02:38:41 good test future proofing thing: add a testExpecte good test future proofing thing: add a testExpected() / check that verifies 10 is indeed larger than the duration if anyone ever swaps the test file it'll catch it DaleCurtis 2014/08/22 19:40:29 duration == infinite, so I can't actually check th Show quoted text On 2014/08/22 02:38:41, scherkus wrote: > good test future proofing thing: add a testExpected() / check that verifies 10 > is indeed larger than the duration > > if anyone ever swaps the test file it'll catch it duration == infinite, so I can't actually check that :) See the check for infinite duration above.
	20 test('video.currentTime <= video.buffered.end(0)');

	21 endTest();

	22 });

	23

	24 waitForEventOnce('loadeddata', function() {

	25 testExpected('video.buffered.length', 1, '==');

	26 testExpected('video.buffered.start(0)', 0, '>=');

	27 testExpected('video.buffered.end(0)', Infinity, '!=');

	28 testExpected('video.currentTime', 0, '==');

	29 testExpected('video.duration', Infinity, '==');

	30 video.play();

	31 });

	32

	33 function start() {

	34 video.src = 'resources/test-live.webm';
	scherkus (not reviewing) 2014/08/22 02:38:41 you should use findMediaFile() (check out other te you should use findMediaFile() (check out other tests) DaleCurtis 2014/08/22 19:40:29 findMediaFile won't work here since it doesn't und Show quoted text On 2014/08/22 02:38:41, scherkus wrote: > you should use findMediaFile() (check out other tests) findMediaFile won't work here since it doesn't understand webm.
	35 }

	36 </script>

	37 </body>

	38 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/media/resources/test-live.webm ('k') | LayoutTests/media/video-buffered-unknown-duration-expected.txt » ('j') | no next file with comments »