LayoutTests/http/tests/media/video-buffered-unknown-duration.html - Issue 499513002: Add layout test and test media for infinite duration tests.

Side by Side Diff: LayoutTests/http/tests/media/video-buffered-unknown-duration.html

Issue 499513002: Add layout test and test media for infinite duration tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/media/resources/test-live.webm ('k') | LayoutTests/http/tests/media/video-buffered-unknown-duration-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	scherkus (not reviewing) 2014/08/22 01:07:34 add <!DOCTYPE html> -- the official doctype of htm add <!DOCTYPE html> -- the official doctype of html5! DaleCurtis 2014/08/22 01:55:07 Done. Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > add <!DOCTYPE html> -- the official doctype of html5! Done.
	2 <head>
	scherkus (not reviewing) 2014/08/22 01:07:33 nit: drop empty head nit: drop empty head DaleCurtis 2014/08/22 01:55:08 Done. Show quoted text On 2014/08/22 01:07:33, scherkus wrote: > nit: drop empty head Done.
	3 </head>

	4 <body onload="start()">

	5 <p>Load a video via preloading; verify infinite duration. Start playback and
	scherkus (not reviewing) 2014/08/22 01:07:33 Prehaps rewords this to say "loading a file with u Prehaps rewords this to say "loading a file with unknown duration to verify that it contains an infinite duration blah blah blah" (the loading via preloading bit confuses me) DaleCurtis 2014/08/22 01:55:08 Done. Show quoted text On 2014/08/22 01:07:33, scherkus wrote: > Prehaps rewords this to say "loading a file with unknown duration to verify that > it contains an infinite duration blah blah blah" > > (the loading via preloading bit confuses me) Done.
	6 ensure currentTime < end of the buffered range upon first timeupdate.</p>

	7 <video id="video" preload="auto"></video>
	scherkus (not reviewing) 2014/08/22 01:07:34 nit: no need for an id nit: no need for an id scherkus (not reviewing) 2014/08/22 01:07:34 nit: default preload attribute is auto nit: default preload attribute is auto DaleCurtis 2014/08/22 01:55:07 Done. Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > nit: no need for an id Done. DaleCurtis 2014/08/22 01:55:08 Done. Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > nit: default preload attribute is auto Done.
	8 <script src=../../media-resources/video-test.js></script>
	scherkus (not reviewing) 2014/08/22 01:07:33 nit: "" all attribute strings nit: "" all attribute strings DaleCurtis 2014/08/22 01:55:08 Done. Show quoted text On 2014/08/22 01:07:33, scherkus wrote: > nit: "" all attribute strings Done.
	9 <script src=../../media-resources/media-file.js></script>

	10 <script>

	11 waitForEventOnce('timeupdate', function() {

	12 video.pause();

	13

	14 testExpected("video.duration", Infinity, "==");
	scherkus (not reviewing) 2014/08/22 01:07:34 nit: javascript uses ' over " for all strings nit: javascript uses ' over " for all strings DaleCurtis 2014/08/22 01:55:07 Done. Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > nit: javascript uses ' over " for all strings Done.
	15 testExpected("video.buffered.start(0)", 0, ">=");

	16

	17 // 1000 arbitrarily chosen, just some value > duration for testing for
	scherkus (not reviewing) 2014/08/22 01:07:34 would duration + 1 suffice? or just compare > dur would duration + 1 suffice? or just compare > duration? DaleCurtis 2014/08/22 01:55:07 I want it to be immune to any future minor changes Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > would duration + 1 suffice? > > or just compare > duration? I want it to be immune to any future minor changes in duration parsing, so I'll just use 10 seconds.
	18 // overflow of an infinite duration.

	19 testExpected("video.buffered.end(0)", 1000, "<");

	20 test("video.currentTime <= video.buffered.end(0)", true);
	scherkus (not reviewing) 2014/08/22 01:07:34 boy oh boy does video-test.js contain some real ge boy oh boy does video-test.js contain some real gems -- it's not widely used in .html files and it certainly confused me because I didn't understand how this test was going to end in other words, I'd rather see explicit testExpected() code followed by a call to endTest() DaleCurtis 2014/08/22 01:55:07 Don't want to use testExpected() since it will pri Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > boy oh boy does video-test.js contain some real gems -- it's not widely used in > .html files and it certainly confused me because I didn't understand how this > test was going to end > > in other words, I'd rather see explicit testExpected() code followed by a call > to endTest() Don't want to use testExpected() since it will print the actual value of video.buffered.end() into the layout test. If timeupdates fire differently on bots etc, that would lead to flaky failures. I did ditch the magic test ending parameter :)
	21 });

	22

	23 waitForEventOnce('loadeddata', function() {

	24 testExpected("video.buffered.length", 1, "==");

	25 testExpected("video.buffered.start(0)", 0, ">=");

	26 testExpected("video.buffered.end(0)", Infinity, "!=");

	27 testExpected("video.currentTime", 0, "==");

	28 testExpected("video.duration", Infinity, "==");

	29 video.play();

	30 });

	31

	32 function start () {
	scherkus (not reviewing) 2014/08/22 01:07:33 nit: remove space before () nit: remove space before () DaleCurtis 2014/08/22 01:55:08 Done. Show quoted text On 2014/08/22 01:07:33, scherkus wrote: > nit: remove space before () Done.
	33 video = document.getElementById('video');
	scherkus (not reviewing) 2014/08/22 01:07:34 funny enough by loading the video-test.js script i funny enough by loading the video-test.js script it does this for you (check out findMediaElement()) DaleCurtis 2014/08/22 01:55:08 Done. Show quoted text On 2014/08/22 01:07:34, scherkus wrote: > funny enough by loading the video-test.js script it does this for you (check out > findMediaElement()) Done.
	34 video.src = "http://127.0.0.1:8000/media/video-throttled-load.cgi?nph=1& name=resources/test-live.webm&throttle=100&type=video/webm";
	scherkus (not reviewing) 2014/08/22 01:07:33 do you need to run this through the cgi? would po do you need to run this through the cgi? would pointing at "/media/resources/test-live.webm" suffice? also does loading over HTTP make a difference? if not, we can plop this file into LayoutTests/media/ instead of http/tests/media/ DaleCurtis 2014/08/22 01:55:08 Looks like it works either way, moved. Show quoted text On 2014/08/22 01:07:33, scherkus wrote: > do you need to run this through the cgi? > > would pointing at "/media/resources/test-live.webm" suffice? > > also does loading over HTTP make a difference? if not, we can plop this file > into LayoutTests/media/ instead of http/tests/media/ Looks like it works either way, moved.
	35 }

	36 </script>

	37 </body>

	38 </html>

OLD	NEW