Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Issue 499493002: dragend fix for mac <webview>. (Closed)

Created:
6 years, 4 months ago by lazyboy
Modified:
6 years, 4 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

dragend fix for mac <webview>. dragend would never fire on mac because BrowserPluginEmbedder::SystemDragEnded() clears |guest_dragging_over_|, which stops BrowserPluginEmbedder::DragSourceEndedAt() to send the dragend message. This isn't an issue in aura b/c, we see DrageSourceEndedAt() before SystemDragEnded(). BUG=401941 Test=On mac, load a <webview> in a chrome app, register a "dragend" listener to a draggable div. Drag that div, observe "dragend" listener firing properly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291356

Patch Set 1 #

Patch Set 2 : clean up for review #

Total comments: 2

Patch Set 3 : address comments from Fady #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 2 4 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lazyboy
6 years, 4 months ago (2014-08-21 23:26:43 UTC) #1
Fady Samuel
https://chromiumcodereview.appspot.com/499493002/diff/20001/content/browser/browser_plugin/browser_plugin_embedder.cc File content/browser/browser_plugin/browser_plugin_embedder.cc (right): https://chromiumcodereview.appspot.com/499493002/diff/20001/content/browser/browser_plugin/browser_plugin_embedder.cc#newcode32 content/browser/browser_plugin/browser_plugin_embedder.cc:32: seen_drag_source_ended_at_(false), Can we do this with one flag?
6 years, 4 months ago (2014-08-21 23:36:31 UTC) #2
lazyboy
Comments addressed in patchset #3 https://chromiumcodereview.appspot.com/499493002/diff/20001/content/browser/browser_plugin/browser_plugin_embedder.cc File content/browser/browser_plugin/browser_plugin_embedder.cc (right): https://chromiumcodereview.appspot.com/499493002/diff/20001/content/browser/browser_plugin/browser_plugin_embedder.cc#newcode32 content/browser/browser_plugin/browser_plugin_embedder.cc:32: seen_drag_source_ended_at_(false), On 2014/08/21 23:36:31, ...
6 years, 4 months ago (2014-08-22 00:03:27 UTC) #3
Fady Samuel
lgtm
6 years, 4 months ago (2014-08-22 00:27:23 UTC) #4
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 4 months ago (2014-08-22 00:54:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/499493002/40001
6 years, 4 months ago (2014-08-22 00:59:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 02:50:53 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 07:35:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291356

Powered by Google App Engine
This is Rietveld 408576698