Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 499443003: Update comment for entryBoxClick(event) so it's more clear. (Closed)

Created:
6 years, 4 months ago by hcarmona
Modified:
6 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@history_bug
Project:
chromium
Visibility:
Public.

Description

Update comment for entryBoxClick(event) so it's more clear. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291535

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/history/history.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
hcarmona
This is just a change in the comment.
6 years, 4 months ago (2014-08-21 21:37:29 UTC) #1
Dan Beam
lgtm
6 years, 4 months ago (2014-08-21 21:40:57 UTC) #2
hcarmona
The CQ bit was checked by hcarmona@chromium.org
6 years, 4 months ago (2014-08-22 17:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hcarmona@chromium.org/499443003/1
6 years, 4 months ago (2014-08-22 17:12:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 17:14:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/history/history.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-22 17:14:07 UTC) #6
hcarmona
The CQ bit was checked by hcarmona@chromium.org
6 years, 4 months ago (2014-08-22 22:00:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hcarmona@chromium.org/499443003/1
6 years, 4 months ago (2014-08-22 22:02:22 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 22:07:10 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/history/history.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-22 22:07:11 UTC) #10
hcarmona
The CQ bit was checked by hcarmona@chromium.org
6 years, 4 months ago (2014-08-22 22:31:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hcarmona@chromium.org/499443003/20001
6 years, 4 months ago (2014-08-22 22:32:38 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 22:33:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291535

Powered by Google App Engine
This is Rietveld 408576698