Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 499433003: Fix tap target consistency with link highlighting and hover/active (Closed)

Created:
6 years, 4 months ago by Rick Byers
Modified:
6 years, 4 months ago
Reviewers:
Zeeshan Qureshi
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, bokan, mustaq
Project:
blink
Visibility:
Public.

Description

Fix tap target consistency with link highlighting and hover/active Touch adjustment doesn't always return the correct node for a point. This used to be masked by extra hit tests, but in crbug.com/381728 I attempted to remove redundant hit tests for better performance. I added an explicit redundant hit-test back in crbug.com/396652 but only for the tap event handling, not for GestureShowPress. This moves that temporary additional hit-test back so that it applies to all types of gesture events that involve touch adjustment. BUG=405508 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180791

Patch Set 1 #

Patch Set 2 : Add optimization (against master - for testing) #

Patch Set 3 : Standalone patch (for review) #

Total comments: 1

Patch Set 4 : Merge with trunk #

Patch Set 5 : Minor tweak to fix new mainframe scrollbar case #

Patch Set 6 : Fix scrollbar case #

Messages

Total messages: 17 (0 generated)
Rick Byers
Zeeshan, PTAL. I'll need to wait for https://codereview.chromium.org/495163002/ to land before I can land this.
6 years, 4 months ago (2014-08-22 14:14:44 UTC) #1
Zeeshan Qureshi
lgtm https://codereview.chromium.org/499433003/diff/40001/LayoutTests/compositing/gestures/gesture-tapHighlight-adjustment-clipping-expected.html File LayoutTests/compositing/gestures/gesture-tapHighlight-adjustment-clipping-expected.html (right): https://codereview.chromium.org/499433003/diff/40001/LayoutTests/compositing/gestures/gesture-tapHighlight-adjustment-clipping-expected.html#newcode1 LayoutTests/compositing/gestures/gesture-tapHighlight-adjustment-clipping-expected.html:1: <!DOCTYPE html> This is to generate the pixel ...
6 years, 4 months ago (2014-08-22 15:17:16 UTC) #2
Rick Byers
On 2014/08/22 15:17:16, Zeeshan Qureshi wrote: > lgtm Thanks for the super-fast turnaround! > https://codereview.chromium.org/499433003/diff/40001/LayoutTests/compositing/gestures/gesture-tapHighlight-adjustment-clipping-expected.html ...
6 years, 4 months ago (2014-08-22 16:04:19 UTC) #3
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 4 months ago (2014-08-22 16:08:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/499433003/60001
6 years, 4 months ago (2014-08-22 16:09:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 17:10:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 17:11:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20846)
6 years, 4 months ago (2014-08-22 17:11:58 UTC) #8
Zeeshan Qureshi
lgtm to the scrollbar fix.
6 years, 4 months ago (2014-08-22 19:42:38 UTC) #9
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 4 months ago (2014-08-22 19:42:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/499433003/100001
6 years, 4 months ago (2014-08-22 19:42:57 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 20:40:41 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 20:43:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8405)
6 years, 4 months ago (2014-08-22 20:43:07 UTC) #14
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 4 months ago (2014-08-22 20:52:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/499433003/100001
6 years, 4 months ago (2014-08-22 20:53:23 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 20:58:52 UTC) #17
Message was sent while issue was closed. 
Committed patchset #6 (100001) as 180791

Powered by Google App Engine
This is Rietveld 408576698